Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-18 Thread Peter Xu
On Mon, Dec 18, 2017 at 09:10:53AM +, Stefan Hajnoczi wrote: > On Mon, Dec 18, 2017 at 01:26:49PM +0800, Peter Xu wrote: > > On Sat, Dec 16, 2017 at 09:23:22AM +, Stefan Hajnoczi wrote: > > > On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > > > > On Wed, Dec 13, 2017 at 08:09:38P

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-18 Thread Stefan Hajnoczi
On Mon, Dec 18, 2017 at 01:26:49PM +0800, Peter Xu wrote: > On Sat, Dec 16, 2017 at 09:23:22AM +, Stefan Hajnoczi wrote: > > On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > > > On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote: > > > > On Tue, Dec 05, 2017 at 01:51:50P

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-17 Thread Peter Xu
On Sat, Dec 16, 2017 at 09:23:22AM +, Stefan Hajnoczi wrote: > On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > > On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote: > > > On Tue, Dec 05, 2017 at 01:51:50PM +0800, Peter Xu wrote: > > > > @@ -3956,12 +3968,122 @@ static v

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-16 Thread Stefan Hajnoczi
On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 01:51:50PM +0800, Peter Xu wrote: > > > @@ -3956,12 +3968,122 @@ static void handle_qmp_command(JSONMessageParser > > > *parser, GQueue *tokens,

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-15 Thread Peter Xu
On Sat, Dec 16, 2017 at 02:37:03PM +0800, Peter Xu wrote: > On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote: > > On Tue, Dec 05, 2017 at 01:51:50PM +0800, Peter Xu wrote: > > > @@ -3956,12 +3968,122 @@ static void handle_qmp_command(JSONMessageParser > > > *parser, GQueue *tokens,

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-15 Thread Peter Xu
On Wed, Dec 13, 2017 at 08:09:38PM +, Stefan Hajnoczi wrote: > On Tue, Dec 05, 2017 at 01:51:50PM +0800, Peter Xu wrote: > > @@ -3956,12 +3968,122 @@ static void handle_qmp_command(JSONMessageParser > > *parser, GQueue *tokens, > > } > > } > > > > -err_out: > > -monitor_qmp

Re: [Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-13 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 01:51:50PM +0800, Peter Xu wrote: > @@ -3956,12 +3968,122 @@ static void handle_qmp_command(JSONMessageParser > *parser, GQueue *tokens, > } > } > > -err_out: > -monitor_qmp_respond(mon, rsp, err, id); > +/* Respond if necessary */ > +monitor_qmp

[Qemu-devel] [RFC v5 16/26] monitor: separate QMP parser and dispatcher

2017-12-04 Thread Peter Xu
Originally QMP goes throw these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |