Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-11-09 Thread Cornelia Huck
On Wed, 31 Oct 2018 16:56:54 + Alex Bennée wrote: > Emilio G. Cota writes: > > > On Wed, Oct 31, 2018 at 16:13:05 +, Alex Bennée wrote: > >> > @@ -353,10 +355,12 @@ void s390_cpu_unhalt(S390CPU *cpu) > >> > CPUState *cs = CPU(cpu); > >> > trace_cpu_unhalt(cs->cpu_index); > >

Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-10-31 Thread Alex Bennée
Emilio G. Cota writes: > On Wed, Oct 31, 2018 at 16:13:05 +, Alex Bennée wrote: >> > @@ -353,10 +355,12 @@ void s390_cpu_unhalt(S390CPU *cpu) >> > CPUState *cs = CPU(cpu); >> > trace_cpu_unhalt(cs->cpu_index); >> > >> > -if (cs->halted) { >> > -cs->halted = 0; >> > +

Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-10-31 Thread Emilio G. Cota
On Wed, Oct 31, 2018 at 16:13:05 +, Alex Bennée wrote: > > @@ -353,10 +355,12 @@ void s390_cpu_unhalt(S390CPU *cpu) > > CPUState *cs = CPU(cpu); > > trace_cpu_unhalt(cs->cpu_index); > > > > -if (cs->halted) { > > -cs->halted = 0; > > +cpu_mutex_lock(cs); > > +if (c

Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-10-31 Thread Alex Bennée
Emilio G. Cota writes: > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Alexander Graf > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > > static unsigned s390_count_running_cpus(void) > @@ -340,10 +340,12 @

[Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-10-25 Thread Emilio G. Cota
Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- hw/intc/s390_flic.c| 2 +- target/s390x/cpu.c | 18 +++--- target/s390x/excp_helper.c |