Re: [Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-20 Thread Jan Kiszka
On 2011-07-20 16:48, Avi Kivity wrote: > On 07/20/2011 05:45 PM, Jan Kiszka wrote: >>> >>> (that's the whole point - it can be made invisible by something outside >>> the cirrus card's knowledge). >>> >>> Note - with kvm, there is still a race between syncing the bitmap and >>> removing the reg

Re: [Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-20 Thread Avi Kivity
On 07/20/2011 05:45 PM, Jan Kiszka wrote: On 2011-07-20 16:40, Avi Kivity wrote: > On 07/20/2011 05:05 PM, Jan Kiszka wrote: >> On 2011-07-17 13:13, Avi Kivity wrote: >>> Convert all vga memory to the memory API. Note we need to fall back to >>> get_system_memory(), since the various buses

Re: [Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-20 Thread Avi Kivity
On 07/20/2011 05:52 PM, Jan Kiszka wrote: > > Hmm, I guess you could just mark the entire range dirty after removing it. Maybe. So the problem is that the dirty bitmap is lost when we unregister a region with the KVM kernel? Yes. What I'd like is an atomic API to replace the entire memory m

Re: [Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-20 Thread Jan Kiszka
On 2011-07-20 16:40, Avi Kivity wrote: > On 07/20/2011 05:05 PM, Jan Kiszka wrote: >> On 2011-07-17 13:13, Avi Kivity wrote: >>> Convert all vga memory to the memory API. Note we need to fall back to >>> get_system_memory(), since the various buses don't pass the vga window >>> as a memory regi

Re: [Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-20 Thread Avi Kivity
On 07/20/2011 05:05 PM, Jan Kiszka wrote: On 2011-07-17 13:13, Avi Kivity wrote: > Convert all vga memory to the memory API. Note we need to fall back to > get_system_memory(), since the various buses don't pass the vga window > as a memory region. > > > if (limit> 0) { > -/*

Re: [Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-20 Thread Jan Kiszka
On 2011-07-17 13:13, Avi Kivity wrote: > Convert all vga memory to the memory API. Note we need to fall back to > get_system_memory(), since the various buses don't pass the vga window > as a memory region. > > Signed-off-by: Avi Kivity > --- > hw/cirrus_vga.c | 345 >

[Qemu-devel] [RFC v4 23/58] vga: convert vga and its derivatives to the memory API

2011-07-17 Thread Avi Kivity
Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. Signed-off-by: Avi Kivity --- hw/cirrus_vga.c | 345 +-- hw/qxl-render.c |2