Re: [Qemu-devel] [RFC v3 48/56] ppc: acquire the BQL in cpu_has_work

2018-10-21 Thread Richard Henderson
On 10/20/18 5:31 PM, Emilio G. Cota wrote: > I like this. How does the appended look? > > Thanks, > > Emilio > ---8<--- > > [PATCH] cpu: introduce cpu_has_work_with_iothread_lock I might just inline cpu_has_work_bql into the one caller. You could even share has_cpu_lock with the c

Re: [Qemu-devel] [RFC v3 48/56] ppc: acquire the BQL in cpu_has_work

2018-10-20 Thread Emilio G. Cota
On Fri, Oct 19, 2018 at 08:58:31 +0200, Paolo Bonzini wrote: > On 19/10/2018 03:06, Emilio G. Cota wrote: > > Soon we will call cpu_has_work without the BQL. > > > > Cc: David Gibson > > Cc: Alexander Graf > > Cc: qemu-...@nongnu.org > > Signed-off-by: Emilio G. Cota > > --- > > target/ppc/tra

Re: [Qemu-devel] [RFC v3 48/56] ppc: acquire the BQL in cpu_has_work

2018-10-18 Thread Paolo Bonzini
On 19/10/2018 03:06, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: David Gibson > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Emilio G. Cota > --- > target/ppc/translate_init.inc.c | 77 +++-- > 1 file changed, 73

[Qemu-devel] [RFC v3 48/56] ppc: acquire the BQL in cpu_has_work

2018-10-18 Thread Emilio G. Cota
Soon we will call cpu_has_work without the BQL. Cc: David Gibson Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Emilio G. Cota --- target/ppc/translate_init.inc.c | 77 +++-- 1 file changed, 73 insertions(+), 4 deletions(-) diff --git a/target/ppc/transl