Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-19 Thread Wei Xu
On Wed, Jun 06, 2018 at 11:41:18AM +0800, Jason Wang wrote: > > > On 2018年06月06日 11:38, Wei Xu wrote: > >>>+ > >>>+head = vq->last_avail_idx; > >>>+i = head; > >>>+ > >>>+caches = vring_get_region_caches(vq); > >>>+cache = &caches->desc; > >>>+vring_packed_desc_read(vdev, &des

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 11:38, Wei Xu wrote: + +head = vq->last_avail_idx; +i = head; + +caches = vring_get_region_caches(vq); +cache = &caches->desc; +vring_packed_desc_read(vdev, &desc, cache, i); I think we'd better find a way to avoid reading descriptor twice. Do you mean here

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread Wei Xu
On Wed, Jun 06, 2018 at 11:29:54AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Signed-off-by: Wei Xu > >--- > > hw/virtio/virtio.c | 145 > > - > > 1 file changed, 144 insertions(+), 1 d

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread Jason Wang
On 2018年06月06日 03:08, w...@redhat.com wrote: From: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 145 - 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index cdbb5af..0160d0

[Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-05 Thread wexu
From: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 145 - 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index cdbb5af..0160d03 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/vi