Re: [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event

2018-06-04 Thread Peter Xu
On Mon, Jun 04, 2018 at 12:59:04PM +0800, Peter Xu wrote: > On Thu, May 31, 2018 at 09:42:23AM -0500, Eric Blake wrote: > > On 05/31/2018 12:16 AM, Peter Xu wrote: > > > This event is not really necessary. After OOB series it might affect > > > the timing of the script so this event may or may not

Re: [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event

2018-06-03 Thread Peter Xu
On Thu, May 31, 2018 at 09:42:23AM -0500, Eric Blake wrote: > On 05/31/2018 12:16 AM, Peter Xu wrote: > > This event is not really necessary. After OOB series it might affect > > the timing of the script so this event may or may not be there comparing > > to the old *.out results. Let's just filt

Re: [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event

2018-05-31 Thread Eric Blake
On 05/31/2018 12:16 AM, Peter Xu wrote: This event is not really necessary. After OOB series it might affect the timing of the script so this event may or may not be there comparing to the old *.out results. Let's just filter it out. This is worrying. Are you stating that the SHUTDOWN event c

[Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event

2018-05-30 Thread Peter Xu
This event is not really necessary. After OOB series it might affect the timing of the script so this event may or may not be there comparing to the old *.out results. Let's just filter it out. Since some of the scripts are using qmp-pretty, we need some trick in the filtering script to make sur