Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2016 at 09:02:53AM -0500, Aaron Conole wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Nov 23, 2016 at 11:42:52AM +0800, Jason Wang wrote: > >> > > > > > > > Seems to me like an easy way to get out of sync. > >> > > > > > > >> > > > > >If we send it to the backend, that has a

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-23 Thread Aaron Conole
"Michael S. Tsirkin" writes: > On Wed, Nov 23, 2016 at 11:42:52AM +0800, Jason Wang wrote: >> > > > > > > > Seems to me like an easy way to get out of sync. >> > > > > > >> > > > > >If we send it to the backend, that has a chance to check >> > > > > >mtu and disconnect on error. >> > > > >> > >

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-22 Thread Michael S. Tsirkin
On Wed, Nov 23, 2016 at 11:42:52AM +0800, Jason Wang wrote: > > > > > > > > Seems to me like an easy way to get out of sync. > > > > > > > > > > > >If we send it to the backend, that has a chance to check > > > > > >mtu and disconnect on error. > > > > > > > >For vhost-user backend, we can send it

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-22 Thread Jason Wang
On 2016年11月23日 04:38, Michael S. Tsirkin wrote: On Tue, Nov 22, 2016 at 06:56:43PM +0100, Maxime Coquelin wrote: > > >On 11/22/2016 03:41 PM, Michael S. Tsirkin wrote: > >On Tue, Nov 22, 2016 at 09:32:01AM -0500, Aaron Conole wrote: > > >Maxime Coquelin writes: > > > > > > >On 11/22/2016 0

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2016 at 06:56:43PM +0100, Maxime Coquelin wrote: > > > On 11/22/2016 03:41 PM, Michael S. Tsirkin wrote: > > On Tue, Nov 22, 2016 at 09:32:01AM -0500, Aaron Conole wrote: > > > Maxime Coquelin writes: > > > > > > > On 11/22/2016 05:07 AM, Jason Wang wrote: > > > > > > > > > >

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-22 Thread Maxime Coquelin
On 11/22/2016 03:41 PM, Michael S. Tsirkin wrote: On Tue, Nov 22, 2016 at 09:32:01AM -0500, Aaron Conole wrote: Maxime Coquelin writes: On 11/22/2016 05:07 AM, Jason Wang wrote: On 2016年11月22日 00:23, Michael S. Tsirkin wrote: On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote:

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2016 at 09:32:01AM -0500, Aaron Conole wrote: > Maxime Coquelin writes: > > > On 11/22/2016 05:07 AM, Jason Wang wrote: > >> > >> > >> On 2016年11月22日 00:23, Michael S. Tsirkin wrote: > >>> On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: > Maxime Coquelin writes

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-22 Thread Aaron Conole
Maxime Coquelin writes: > On 11/22/2016 05:07 AM, Jason Wang wrote: >> >> >> On 2016年11月22日 00:23, Michael S. Tsirkin wrote: >>> On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: Maxime Coquelin writes: > On 11/18/2016 07:15 PM, Aaron Conole wrote: >> Maxime Coqueli

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-21 Thread Maxime Coquelin
On 11/22/2016 05:07 AM, Jason Wang wrote: On 2016年11月22日 00:23, Michael S. Tsirkin wrote: On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: Maxime Coquelin writes: On 11/18/2016 07:15 PM, Aaron Conole wrote: Maxime Coquelin writes: This series implements Virtio spec updat

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-21 Thread Jason Wang
On 2016年11月22日 00:23, Michael S. Tsirkin wrote: On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: Maxime Coquelin writes: On 11/18/2016 07:15 PM, Aaron Conole wrote: Maxime Coquelin writes: This series implements Virtio spec update from Aaron Conole which defines a way for t

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-21 Thread Michael S. Tsirkin
On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: > Maxime Coquelin writes: > > > On 11/18/2016 07:15 PM, Aaron Conole wrote: > >> Maxime Coquelin writes: > >> > >>> This series implements Virtio spec update from Aaron Conole which > >>> defines a way for the host to expose its max M

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-18 Thread Aaron Conole
Maxime Coquelin writes: > On 11/18/2016 07:15 PM, Aaron Conole wrote: >> Maxime Coquelin writes: >> >>> This series implements Virtio spec update from Aaron Conole which >>> defines a way for the host to expose its max MTU to the guest. >>> >>> Changes since RFC v1: >>> - >>>

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-18 Thread Maxime Coquelin
On 11/18/2016 07:15 PM, Aaron Conole wrote: Maxime Coquelin writes: This series implements Virtio spec update from Aaron Conole which defines a way for the host to expose its max MTU to the guest. Changes since RFC v1: - - Rebased on top of v2.8.0-rc0 (2.7.90) - Write

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-18 Thread Aaron Conole
Maxime Coquelin writes: > This series implements Virtio spec update from Aaron Conole which > defines a way for the host to expose its max MTU to the guest. > > Changes since RFC v1: > - > - Rebased on top of v2.8.0-rc0 (2.7.90) > - Write MTU unconditionnaly in netcfg to avo

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-17 Thread John Fastabend
On 16-11-17 02:34 PM, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 10:58:04PM +0100, Maxime Coquelin wrote: >> This series implements Virtio spec update from Aaron Conole which >> defines a way for the host to expose its max MTU to the guest. >> >> Changes since RFC v1: >> --

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-17 Thread Michael S. Tsirkin
On Thu, Nov 17, 2016 at 10:58:04PM +0100, Maxime Coquelin wrote: > This series implements Virtio spec update from Aaron Conole which > defines a way for the host to expose its max MTU to the guest. > > Changes since RFC v1: > - > - Rebased on top of v2.8.0-rc0 (2.7.90) > - Wr

[Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

2016-11-17 Thread Maxime Coquelin
This series implements Virtio spec update from Aaron Conole which defines a way for the host to expose its max MTU to the guest. Changes since RFC v1: - - Rebased on top of v2.8.0-rc0 (2.7.90) - Write MTU unconditionnaly in netcfg to avoid memory leak (Paolo) - Add host_mtu