Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-16 Thread Avi Kivity
On 10/15/2012 09:52 PM, Benjamin Herrenschmidt wrote: >> >> I do have an is_write parameter to translate, in fact I added it in >> order to implement the spapr iommu. Or do you mean something else? > > Hrm, sort of. "is_write" means you can only express RO vs RW. Two > parameter for read and wri

Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-15 Thread Benjamin Herrenschmidt
On Mon, 2012-10-15 at 12:45 +0200, Avi Kivity wrote: > > I haven't had a chance to review in details yet, but one thing I > noticed > > is that you basically have a single read/write protection > information > > for a translation. > > > > This is a loss of functionality to some extent (well, maybe

Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-15 Thread Avi Kivity
On 10/12/2012 04:36 AM, Benjamin Herrenschmidt wrote: > On Thu, 2012-10-11 at 15:26 +0200, Avi Kivity wrote: >> These patches add IOMMU support to the memory core. IOMMUs can be added >> anywhere in >> the memory hierarchy, and may be arranged in series. > > I haven't had a chance to review in de

Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-11 Thread Benjamin Herrenschmidt
On Thu, 2012-10-11 at 15:26 +0200, Avi Kivity wrote: > These patches add IOMMU support to the memory core. IOMMUs can be added > anywhere in > the memory hierarchy, and may be arranged in series. I haven't had a chance to review in details yet, but one thing I noticed is that you basically have a

[Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-11 Thread Avi Kivity
These patches add IOMMU support to the memory core. IOMMUs can be added anywhere in the memory hierarchy, and may be arranged in series. Avi Kivity (7): memory: fix address space initialization/destruction memory: limit sections in the radix tree to the actual address space size memory: