Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-30 Thread Benoît Canet
Le Friday 27 Sep 2013 à 12:03:07 (+0200), Kevin Wolf a écrit : > Am 26.09.2013 um 18:29 hat Benoît Canet geschrieben: > > Le Friday 08 Feb 2013 à 11:38:38 (+0100), Kevin Wolf a écrit : > > > Am 28.01.2013 18:07, schrieb Benoît Canet: > > > > Signed-off-by: Benoit Canet > > > > --- > > > > block/q

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-27 Thread Kevin Wolf
Am 26.09.2013 um 18:29 hat Benoît Canet geschrieben: > Le Friday 08 Feb 2013 à 11:38:38 (+0100), Kevin Wolf a écrit : > > Am 28.01.2013 18:07, schrieb Benoît Canet: > > > Signed-off-by: Benoit Canet > > > --- > > > block/quorum.c | 111 > > > +

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-27 Thread Kevin Wolf
Am 26.09.2013 um 18:16 hat Benoît Canet geschrieben: > > > +static void quorum_aio_bh(void *opaque) > > > +{ > > > +QuorumAIOCB *acb = opaque; > > > +BDRVQuorumState *s = acb->bqs; > > > +int ret; > > > + > > > +ret = s->threshold <= acb->success_count ? 0 : -EIO; > > > > It would

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-26 Thread Benoît Canet
Le Friday 08 Feb 2013 à 11:38:38 (+0100), Kevin Wolf a écrit : > Am 28.01.2013 18:07, schrieb Benoît Canet: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 111 > > > > 1 file changed, 111 insertions(+) > > > > diff --git a/

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-26 Thread Benoît Canet
> > +static void quorum_aio_bh(void *opaque) > > +{ > > +QuorumAIOCB *acb = opaque; > > +BDRVQuorumState *s = acb->bqs; > > +int ret; > > + > > +ret = s->threshold <= acb->success_count ? 0 : -EIO; > > It would be very much preferable if you stored the actual error code > instead o

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-26 Thread Benoît Canet
Le Friday 08 Feb 2013 à 11:38:38 (+0100), Kevin Wolf a écrit : > Am 28.01.2013 18:07, schrieb Benoît Canet: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 111 > > > > 1 file changed, 111 insertions(+) > > > > diff --git a/

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-02-08 Thread Kevin Wolf
Am 28.01.2013 18:07, schrieb Benoît Canet: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 111 > > 1 file changed, 111 insertions(+) > > diff --git a/block/quorum.c b/block/quorum.c > index d8fffbe..5d8470b 100644 > --- a/block/q

[Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 111 1 file changed, 111 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index d8fffbe..5d8470b 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -52,11 +52,122 @@ struct Quoru