Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.

2013-02-28 Thread Stefan Hajnoczi
On Wed, Feb 27, 2013 at 03:53:43PM +0100, Benoît Canet wrote: > > > inc_refcounts(bs, res, refcount_table, refcount_table_size, > > > -l2_offset, s->cluster_size); > > > +l2_offset, dedup ? s->hash_block_size : s->l2_size << 3); > > > > Why s->l2_size <

Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.

2013-02-27 Thread Benoît Canet
> > inc_refcounts(bs, res, refcount_table, refcount_table_size, > > -l2_offset, s->cluster_size); > > +l2_offset, dedup ? s->hash_block_size : s->l2_size << 3); > > Why s->l2_size << 3 instead of s->cluster_size for the non-dedup case? I wrote it like

Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.

2013-02-08 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:32:04PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 337fb65..d173c18 100644 > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -1051,7 +1051,7 @@ static int check_dedup_l2(BlockDriverState *bs, > BdrvC

[Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.

2013-02-06 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-refcount.c |4 ++-- block/qcow2.c |3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 337fb65..d173c18 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcou