On 01/16/2013 07:50 AM, Benoît Canet wrote:
>> I'd write this as CEIL(dedup_block_size / (32 + 8)) to make it clear
>> that it rounds up...
>
> Isn't it FLOOR instead of CEIL ? (off by one error) ?
Indeed, my reply was a bit too hasty, and I mixed terminology. The
number of entries that fits in
> I'd write this as CEIL(dedup_block_size / (32 + 8)) to make it clear
> that it rounds up...
Isn't it FLOOR instead of CEIL ? (off by one error) ?
Benoît
> > +L2 tables size 64KB is different from
> > +cluster size 4KB.
>
> Umm, doesn't the cluster_bits (bytes 20-23 of the header) determine the
> size of a cluster, rather than assuming a cluster is always 4KB? And
> later on, the spec
On 01/02/2013 09:16 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> docs/specs/qcow2.txt | 100
> +-
> 1 file changed, 99 insertions(+), 1 deletion(-)
>
> diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
> index 36a559d..c9c
Signed-off-by: Benoit Canet
---
docs/specs/qcow2.txt | 100 +-
1 file changed, 99 insertions(+), 1 deletion(-)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 36a559d..c9c0d47 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2