Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-14 Thread Dong Jia
On Tue, 7 Jun 2016 22:29:30 -0600 Alex Williamson wrote: > On Wed, 8 Jun 2016 11:18:42 +0800 > Dong Jia wrote: > > > On Tue, 7 Jun 2016 19:39:21 -0600 > > Alex Williamson wrote: > > > > > On Wed, 8 Jun 2016 01:18:42 + > > > "Tian, Kevin" wrote: > > > > > > > > From: Alex Williamson [m

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Neo Jia
On Wed, Jun 08, 2016 at 02:13:49PM +0800, Dong Jia wrote: > On Tue, 7 Jun 2016 20:48:42 -0700 > Neo Jia wrote: > > > On Wed, Jun 08, 2016 at 11:18:42AM +0800, Dong Jia wrote: > > > On Tue, 7 Jun 2016 19:39:21 -0600 > > > Alex Williamson wrote: > > > > > > > On Wed, 8 Jun 2016 01:18:42 + > >

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Dong Jia
On Tue, 7 Jun 2016 20:48:42 -0700 Neo Jia wrote: > On Wed, Jun 08, 2016 at 11:18:42AM +0800, Dong Jia wrote: > > On Tue, 7 Jun 2016 19:39:21 -0600 > > Alex Williamson wrote: > > > > > On Wed, 8 Jun 2016 01:18:42 + > > > "Tian, Kevin" wrote: > > > > > > > > From: Alex Williamson [mailto:al

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Alex Williamson
On Wed, 8 Jun 2016 11:18:42 +0800 Dong Jia wrote: > On Tue, 7 Jun 2016 19:39:21 -0600 > Alex Williamson wrote: > > > On Wed, 8 Jun 2016 01:18:42 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > > Sent: Wednesday, June 08, 2016 6:42 A

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Neo Jia
On Wed, Jun 08, 2016 at 11:18:42AM +0800, Dong Jia wrote: > On Tue, 7 Jun 2016 19:39:21 -0600 > Alex Williamson wrote: > > > On Wed, 8 Jun 2016 01:18:42 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > > Sent: Wednesday, June 08, 2016 6:

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Dong Jia
On Tue, 7 Jun 2016 19:39:21 -0600 Alex Williamson wrote: > On Wed, 8 Jun 2016 01:18:42 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Wednesday, June 08, 2016 6:42 AM > > > > > > On Tue, 7 Jun 2016 03:03:32 + > > > "Tian, Kevin"

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Alex Williamson
On Wed, 8 Jun 2016 01:18:42 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Wednesday, June 08, 2016 6:42 AM > > > > On Tue, 7 Jun 2016 03:03:32 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, June 08, 2016 6:42 AM > > On Tue, 7 Jun 2016 03:03:32 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Tuesday, June 07, 2016 3:31 AM > > > > > > On Mon, 6 Jun

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-07 Thread Alex Williamson
On Tue, 7 Jun 2016 03:03:32 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, June 07, 2016 3:31 AM > > > > On Mon, 6 Jun 2016 10:44:25 -0700 > > Neo Jia wrote: > > > > > On Mon, Jun 06, 2016 at 04:29:11PM +0800, Dong Jia wrote: > >

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-06 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, June 07, 2016 3:31 AM > > On Mon, 6 Jun 2016 10:44:25 -0700 > Neo Jia wrote: > > > On Mon, Jun 06, 2016 at 04:29:11PM +0800, Dong Jia wrote: > > > On Sun, 5 Jun 2016 23:27:42 -0700 > > > Neo Jia wrote: > > > > > > 2. V

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-06 Thread Alex Williamson
On Mon, 6 Jun 2016 10:44:25 -0700 Neo Jia wrote: > On Mon, Jun 06, 2016 at 04:29:11PM +0800, Dong Jia wrote: > > On Sun, 5 Jun 2016 23:27:42 -0700 > > Neo Jia wrote: > > > > 2. VFIO_DEVICE_CCW_CMD_REQUEST > > This intends to handle an intercepted channel I/O instruction. It > > basically need t

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-06 Thread Neo Jia
On Mon, Jun 06, 2016 at 04:29:11PM +0800, Dong Jia wrote: > On Sun, 5 Jun 2016 23:27:42 -0700 > Neo Jia wrote: > > 2. VFIO_DEVICE_CCW_CMD_REQUEST > This intends to handle an intercepted channel I/O instruction. It > basically need to do the following thing: May I ask how and when QEMU knows that

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-06 Thread Dong Jia
On Sun, 5 Jun 2016 23:27:42 -0700 Neo Jia wrote: > On Mon, Jun 06, 2016 at 02:01:48PM +0800, Dong Jia wrote: > > On Mon, 6 Jun 2016 10:57:49 +0530 > > Kirti Wankhede wrote: > > > > > > > > > > > On 6/3/2016 2:27 PM, Dong Jia wrote: > > > > On Wed, 25 May 2016 01:28:15 +0530 > > > > Kirti Wank

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-05 Thread Neo Jia
On Mon, Jun 06, 2016 at 02:01:48PM +0800, Dong Jia wrote: > On Mon, 6 Jun 2016 10:57:49 +0530 > Kirti Wankhede wrote: > > > > > > > On 6/3/2016 2:27 PM, Dong Jia wrote: > > > On Wed, 25 May 2016 01:28:15 +0530 > > > Kirti Wankhede wrote: > > > > > > > > > ...snip... > > > > > >> +struct phy

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-05 Thread Dong Jia
On Mon, 6 Jun 2016 10:57:49 +0530 Kirti Wankhede wrote: > > > On 6/3/2016 2:27 PM, Dong Jia wrote: > > On Wed, 25 May 2016 01:28:15 +0530 > > Kirti Wankhede wrote: > > > > > > ...snip... > > > >> +struct phy_device_ops { > >> + struct module *owner; > >> + const struct attribute_group *

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-05 Thread Kirti Wankhede
On 6/3/2016 2:27 PM, Dong Jia wrote: > On Wed, 25 May 2016 01:28:15 +0530 > Kirti Wankhede wrote: > > > ...snip... > >> +struct phy_device_ops { >> +struct module *owner; >> +const struct attribute_group **dev_attr_groups; >> +const struct attribute_group **mdev_attr_groups; >>

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-05 Thread Dong Jia
On Fri, 3 Jun 2016 09:40:16 + "Tian, Kevin" wrote: > > From: Dong Jia [mailto:bjsdj...@linux.vnet.ibm.com] > > Sent: Friday, June 03, 2016 4:58 PM > > > > > > ...snip... > > > > > +struct phy_device_ops { > > > + struct module *owner; > > > + const struct attribute_group **dev_attr_group

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-03 Thread Tian, Kevin
> From: Dong Jia [mailto:bjsdj...@linux.vnet.ibm.com] > Sent: Friday, June 03, 2016 4:58 PM > > > ...snip... > > > +struct phy_device_ops { > > + struct module *owner; > > + const struct attribute_group **dev_attr_groups; > > + const struct attribute_group **mdev_attr_groups; > > + > > +

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-03 Thread Dong Jia
On Wed, 25 May 2016 01:28:15 +0530 Kirti Wankhede wrote: ...snip... > +struct phy_device_ops { > + struct module *owner; > + const struct attribute_group **dev_attr_groups; > + const struct attribute_group **mdev_attr_groups; > + > + int (*supported_config)(struct device *

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-27 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Wednesday, May 25, 2016 10:47 PM > > > >> +static struct devices_list { > >> + struct list_headdev_list; > >> + struct mutexlist_lock; > >> +} mdevices, phy_devices; > > > > phy_devices -> pdevices? and similarly we can use pdev/mdev > > pair in other

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-26 Thread Alex Williamson
On Thu, 26 May 2016 14:33:39 +0530 Kirti Wankhede wrote: > Thanks Alex. > > I'll consider all the nits and fix those in next version of patch. > > More below: > > On 5/26/2016 4:09 AM, Alex Williamson wrote: > > On Wed, 25 May 2016 01:28:15 +0530 > > Kirti Wankhede wrote: > > > > ... > >

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-26 Thread Kirti Wankhede
Thanks Alex. I'll consider all the nits and fix those in next version of patch. More below: On 5/26/2016 4:09 AM, Alex Williamson wrote: > On Wed, 25 May 2016 01:28:15 +0530 > Kirti Wankhede wrote: > ... >> + >> +config MDEV >> +tristate "Mediated device driver framework" >> +depends

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-25 Thread Alex Williamson
On Wed, 25 May 2016 01:28:15 +0530 Kirti Wankhede wrote: > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by differnt drivers of different > devices. > > This module provides a generic interface

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-25 Thread Kirti Wankhede
On 5/25/2016 1:25 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Wednesday, May 25, 2016 3:58 AM >> ... >> + >> +config MDEV >> +tristate "Mediated device driver framework" > > Sorry not a native speaker. Is it cleaner to say "Driver framework for Media

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-25 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Wednesday, May 25, 2016 3:58 AM > > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by differnt drivers of different > devices. > > This

[Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-05-24 Thread Kirti Wankhede
Design for Mediated Device Driver: Main purpose of this driver is to provide a common interface for mediated device management that can be used by differnt drivers of different devices. This module provides a generic interface to create the device, add it to mediated bus, add device to IOMMU group