Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

2012-04-02 Thread Stefan Hajnoczi
On Mon, Apr 2, 2012 at 1:52 PM, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > >> On Fri, Mar 30, 2012 at 07:12:46PM +0200, Lluís Vilanova wrote: >>> Stefan Hajnoczi writes: >>> > Only one point: please don't introduce PUBLIC yet.  Let's add it when >>> > it's needed.  At the moment nothing use

Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

2012-04-02 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Mar 30, 2012 at 07:12:46PM +0200, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> > Only one point: please don't introduce PUBLIC yet. Let's add it when >> > it's needed. At the moment nothing uses it. >> >> > I have tested this series with all backends and

Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

2012-04-02 Thread Stefan Hajnoczi
On Fri, Mar 30, 2012 at 07:12:46PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > Only one point: please don't introduce PUBLIC yet. Let's add it when > > it's needed. At the moment nothing uses it. > > > I have tested this series with all backends and looked at the diff > > between

Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

2012-03-30 Thread Lluís Vilanova
Stefan Hajnoczi writes: > Only one point: please don't introduce PUBLIC yet. Let's add it when > it's needed. At the moment nothing uses it. > I have tested this series with all backends and looked at the diff > between the old tracetool and tracetool.py. > I'm happy with this series. We need

Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

2012-03-29 Thread Stefan Hajnoczi
On Tue, Mar 27, 2012 at 09:49:12PM +0200, Lluís Vilanova wrote: > A full rewrite of the tracetool script using per-format and per-backend > modules, > so that it's easier to read and extend it in the future. > > Signed-off-by: Lluís Vilanova > --- > NOTE: This series applies in current master, i

[Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

2012-03-27 Thread Lluís Vilanova
A full rewrite of the tracetool script using per-format and per-backend modules, so that it's easier to read and extend it in the future. Signed-off-by: Lluís Vilanova --- NOTE: This series applies in current master, ignoring the "Rewrite tracetool using python" series. Changes in v3: * S