Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-19 Thread Andreas Färber
Am 16.08.2013 02:20, schrieb Benjamin Herrenschmidt: > On Thu, 2013-08-15 at 16:47 +0200, Andreas Färber wrote: >> When we instantiate a -cpu POWER9 then having one POWER9_vX.Y around to >> back it doesn't really hurt. Unlike ARM's MIDR there doesn't seem to be >> an encoding of IBM vendor or POWER

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-19 Thread Andreas Färber
Am 15.08.2013 13:59, schrieb Alexander Graf: > > On 15.08.2013, at 13:48, Andreas Färber wrote: > >> We do have the following: >> >> "object" >> +- "device" >> +- "cpu" >> +- "powerpc64-cpu" >> +- "POWER7-family-powerpc64-cpu" -> POWERPC_FAMILY() > > Ah, there is the family :). >

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-16 Thread Alexey Kardashevskiy
On 08/16/2013 12:47 AM, Andreas Färber wrote: > Am 15.08.2013 15:55, schrieb Alexey Kardashevskiy: >> On 08/15/2013 09:48 PM, Andreas Färber wrote: >>> Am 15.08.2013 13:03, schrieb Alexander Graf: On 15.08.2013, at 12:52, Andreas Färber wrote: > Am 15.08.2013 10:45, schrieb Alexa

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Benjamin Herrenschmidt
On Thu, 2013-08-15 at 19:28 -0500, Anthony Liguori wrote: > On Thu, Aug 15, 2013 at 7:20 PM, Benjamin Herrenschmidt > wrote: > > On Thu, 2013-08-15 at 16:47 +0200, Andreas Färber wrote: > >> comparing values for closest match. So that if you have a v2.4 and QEMU > >> knows v2.1 and v2.3 we take v2

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Anthony Liguori
On Thu, Aug 15, 2013 at 7:20 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-08-15 at 16:47 +0200, Andreas Färber wrote: >> comparing values for closest match. So that if you have a v2.4 and QEMU >> knows v2.1 and v2.3 we take v2.3 and fill in the v2.4 PVR. > > Another thing to keep in mind is th

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Benjamin Herrenschmidt
On Thu, 2013-08-15 at 16:47 +0200, Andreas Färber wrote: > When we instantiate a -cpu POWER9 then having one POWER9_vX.Y around to > back it doesn't really hurt. Unlike ARM's MIDR there doesn't seem to be > an encoding of IBM vendor or POWER family in the PVR. The macros and > their new implementat

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 18:08, Andreas Färber wrote: > Am 15.08.2013 17:51, schrieb Alexander Graf: >> >> On 15.08.2013, at 17:43, Andreas Färber wrote: >> >>> Am 15.08.2013 17:29, schrieb Alexander Graf: On 15.08.2013, at 16:47, Andreas Färber wrote: > There is nothing wrong wit

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Andreas Färber
Am 15.08.2013 17:51, schrieb Alexander Graf: > > On 15.08.2013, at 17:43, Andreas Färber wrote: > >> Am 15.08.2013 17:29, schrieb Alexander Graf: >>> >>> On 15.08.2013, at 16:47, Andreas Färber wrote: >>> There is nothing wrong with finding a mask or wildcard solution to that problem, I

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 17:43, Andreas Färber wrote: > Am 15.08.2013 17:29, schrieb Alexander Graf: >> >> On 15.08.2013, at 16:47, Andreas Färber wrote: >> >>> There is nothing wrong with finding a mask or wildcard solution to that >>> problem, I already indicated so on the original POWER+ patch. The

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Andreas Färber
Am 15.08.2013 17:29, schrieb Alexander Graf: > > On 15.08.2013, at 16:47, Andreas Färber wrote: > >> There is nothing wrong with finding a mask or wildcard solution to that >> problem, I already indicated so on the original POWER+ patch. The point >> of the whole discussion is how to get there in

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 16:47, Andreas Färber wrote: > Am 15.08.2013 15:55, schrieb Alexey Kardashevskiy: >> On 08/15/2013 09:48 PM, Andreas Färber wrote: >>> Am 15.08.2013 13:03, schrieb Alexander Graf: On 15.08.2013, at 12:52, Andreas Färber wrote: > Am 15.08.2013 10:45, schrieb

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 16:43, Alexey Kardashevskiy wrote: > On 08/15/2013 06:45 PM, Alexander Graf wrote: >> >> On 15.08.2013, at 10:06, Alexey Kardashevskiy wrote: >> >>> On 08/15/2013 05:55 PM, Alexander Graf wrote: On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: > IBM PO

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Andreas Färber
Am 15.08.2013 15:55, schrieb Alexey Kardashevskiy: > On 08/15/2013 09:48 PM, Andreas Färber wrote: >> Am 15.08.2013 13:03, schrieb Alexander Graf: >>> >>> On 15.08.2013, at 12:52, Andreas Färber wrote: >>> Am 15.08.2013 10:45, schrieb Alexander Graf: > > Yes, I think it makes sense to

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexey Kardashevskiy
On 08/15/2013 06:45 PM, Alexander Graf wrote: > > On 15.08.2013, at 10:06, Alexey Kardashevskiy wrote: > >> On 08/15/2013 05:55 PM, Alexander Graf wrote: >>> >>> On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: >>> IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and >

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexey Kardashevskiy
On 08/15/2013 09:48 PM, Andreas Färber wrote: > Am 15.08.2013 13:03, schrieb Alexander Graf: >> >> On 15.08.2013, at 12:52, Andreas Färber wrote: >> >>> Am 15.08.2013 10:45, schrieb Alexander Graf: Yes, I think it makes sense to keep the full PVR around when we want to be specific.

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 13:48, Andreas Färber wrote: > Am 15.08.2013 13:03, schrieb Alexander Graf: >> >> On 15.08.2013, at 12:52, Andreas Färber wrote: >> >>> Am 15.08.2013 10:45, schrieb Alexander Graf: Yes, I think it makes sense to keep the full PVR around when we want to be spec

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Andreas Färber
Am 15.08.2013 13:03, schrieb Alexander Graf: > > On 15.08.2013, at 12:52, Andreas Färber wrote: > >> Am 15.08.2013 10:45, schrieb Alexander Graf: >>> >>> Yes, I think it makes sense to keep the full PVR around when we want to be >>> specific. What I'm referring to is class specific logic that ca

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 12:52, Andreas Färber wrote: > Am 15.08.2013 10:45, schrieb Alexander Graf: >> >> On 15.08.2013, at 10:06, Alexey Kardashevskiy wrote: >> >>> On 08/15/2013 05:55 PM, Alexander Graf wrote: On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: > IBM POWERPC p

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Andreas Färber
Am 15.08.2013 10:45, schrieb Alexander Graf: > > On 15.08.2013, at 10:06, Alexey Kardashevskiy wrote: > >> On 08/15/2013 05:55 PM, Alexander Graf wrote: >>> >>> On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: >>> IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and >>

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 10:06, Alexey Kardashevskiy wrote: > On 08/15/2013 05:55 PM, Alexander Graf wrote: >> >> On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: >> >>> IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and >>> a CPU version in lower 16 bits. Since there is no si

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexey Kardashevskiy
On 08/15/2013 05:55 PM, Alexander Graf wrote: > > On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: > >> IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and >> a CPU version in lower 16 bits. Since there is no significant change >> in behavior between versions, there is no

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexander Graf
On 15.08.2013, at 09:45, Alexey Kardashevskiy wrote: > IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and > a CPU version in lower 16 bits. Since there is no significant change > in behavior between versions, there is no point to add every single CPU > version in QEMU's CPU l

[Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-15 Thread Alexey Kardashevskiy
IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and a CPU version in lower 16 bits. Since there is no significant change in behavior between versions, there is no point to add every single CPU version in QEMU's CPU list. Also, new CPU versions of already supported CPU won't brea