Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Cédric Le Goater
On 09/28/2017 12:03 PM, Benjamin Herrenschmidt wrote: > On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote: >> probably, I just removed the properties under QEMU and could >> boot the guest, with disks and network. > > As long as you don't use LSIs... That I didn't test much. Which the de

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote: > probably, I just removed the properties under QEMU and could > boot the guest, with disks and network. As long as you don't use LSIs... > > > Do you have a DT snapshot from pHyp for me to look at ? > > > # lsprop /proc/device-tree/i

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-21 at 11:35 +1000, David Gibson wrote: > > >> +_FDT(fdt_setprop_string(fdt, node, "device_type", "power-ivpe")); > > >> +_FDT(fdt_setprop(fdt, node, "reg", timas, sizeof(timas))); > > >> + > > >> +_FDT(fdt_setprop_string(fdt, node, "compatible", "ibm,power-ivpe")); > > >

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Cédric Le Goater
On 09/28/2017 10:43 AM, Benjamin Herrenschmidt wrote: > On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote: >> Let me be more precise. I am saying that the interrupt-controller >> and #interrupt-cells properties are not needed under the main interrupt >> controller node. They can be remove

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote: > Let me be more precise. I am saying that the interrupt-controller > and #interrupt-cells properties are not needed under the main interrupt > controller node. They can be removed from the tree and the Linux guest > kernel will boot per

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-22 Thread David Gibson
On Thu, Sep 21, 2017 at 01:21:10PM +0200, Cédric Le Goater wrote: > On 09/21/2017 03:35 AM, David Gibson wrote: > > On Wed, Sep 20, 2017 at 02:26:32PM +0200, Cédric Le Goater wrote: > >> On 09/19/2017 10:44 AM, David Gibson wrote: > >>> On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wro

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-21 Thread Cédric Le Goater
On 09/21/2017 03:35 AM, David Gibson wrote: > On Wed, Sep 20, 2017 at 02:26:32PM +0200, Cédric Le Goater wrote: >> On 09/19/2017 10:44 AM, David Gibson wrote: >>> On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote: Like for XICS, the XIVE interface for the guest is described in t

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-20 Thread David Gibson
On Wed, Sep 20, 2017 at 02:26:32PM +0200, Cédric Le Goater wrote: > On 09/19/2017 10:44 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote: > >> Like for XICS, the XIVE interface for the guest is described in the > >> device tree under the "interrupt-contro

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-20 Thread Cédric Le Goater
On 09/19/2017 10:44 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote: >> Like for XICS, the XIVE interface for the guest is described in the >> device tree under the "interrupt-controller" node. A couple of new >> properties are specific to XIVE : >> >> -

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-19 Thread David Gibson
On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote: > Like for XICS, the XIVE interface for the guest is described in the > device tree under the "interrupt-controller" node. A couple of new > properties are specific to XIVE : > > - "reg" > >contains the base address and size o

[Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-11 Thread Cédric Le Goater
Like for XICS, the XIVE interface for the guest is described in the device tree under the "interrupt-controller" node. A couple of new properties are specific to XIVE : - "reg" contains the base address and size of the thread interrupt managnement areas (TIMA), also called rings, for the U