Re: [Qemu-devel] [RFC PATCH v2] kvm: x86: ignore ioapic polarity

2014-03-13 Thread Gabriel L. Somlo
On Thu, Mar 13, 2014 at 11:53:04AM +0100, Paolo Bonzini wrote: > Instead of this, I'm adding the following to the KVM_IRQ_LINE ioctl: > > +On real hardware, interrupt pins can be active-low or active-high. This > +does not matter for the level field of struct kvm_irq_level: 1 always > +means acti

Re: [Qemu-devel] [RFC PATCH v2] kvm: x86: ignore ioapic polarity

2014-03-13 Thread Paolo Bonzini
Il 28/02/2014 05:06, Gabriel L. Somlo ha scritto: > +NOTE: For each level-triggered interrupt managed by a virtual ioapic, > +the guest OS may set a polarity value (bit 13 of each corresponding I/O > +redirection table register). The polarity bit defines the relationship > +between an irq line's lo

Re: [Qemu-devel] [RFC PATCH v2] kvm: x86: ignore ioapic polarity

2014-03-02 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 11:06:17PM -0500, Gabriel L. Somlo wrote: > Both QEMU and KVM have already accumulated a significant number of > optimizations based on the hard-coded assumption that ioapic polarity > will always use the ActiveHigh convention, where the logical and > physical states of leve

[Qemu-devel] [RFC PATCH v2] kvm: x86: ignore ioapic polarity

2014-02-27 Thread Gabriel L. Somlo
Both QEMU and KVM have already accumulated a significant number of optimizations based on the hard-coded assumption that ioapic polarity will always use the ActiveHigh convention, where the logical and physical states of level-triggered irq lines always match (i.e., active(asserted) == high == 1, i