Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-04 Thread Paolo Bonzini
> > Third, it's probably a bad idea to call this function from generic code, so > > make it static and add the detection function from patch 2/2 already here. > > By making it static, it's also possible to define it only if CONFIG_LINUX > > is defined; the ThunderX detection will then return false

Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-04 Thread Vijay Kilari
Hi Paolo, On Tue, Aug 2, 2016 at 4:18 PM, Paolo Bonzini wrote: > - Original Message - >> From: "vijay kilari" >> To: qemu-...@nongnu.org, "peter maydell" , >> pbonz...@redhat.com >> Cc: qemu-devel@nongnu.org, "Prasun Kapoor" , >> "vijay kilari" , >> "Vijaya Kumar K" >> Sent: Tuesday,

Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-02 Thread Peter Maydell
On 2 August 2016 at 11:20, wrote: > +long int qemu_read_cpuid_info(void) Don't use "long" here, it might be 32 or 64 bits. The kernel ABI for the /sys/ file we're reading says it is a 64-bit value, so uint64_t is what you want. > +{ > +FILE *fp; > +char *buf; > +long int midr = 0; >

Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-02 Thread Paolo Bonzini
- Original Message - > From: "vijay kilari" > To: qemu-...@nongnu.org, "peter maydell" , > pbonz...@redhat.com > Cc: qemu-devel@nongnu.org, "Prasun Kapoor" , "vijay > kilari" , > "Vijaya Kumar K" > Sent: Tuesday, August 2, 2016 12:20:15 PM > Subject: [RFC PATCH v1 1/2] utils: Add helper

[Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-02 Thread vijay . kilari
From: Vijaya Kumar K Add helper API to read MIDR_EL1 registers to fetch cpu identification information. This helps in adding errata's and architecture specific features. This is implemented only for arm architecture. Signed-off-by: Vijaya Kumar K --- include/qemu-common.h |1 + util/Makef