Re: [Qemu-devel] [RFC PATCH v0 8/9] target-i386: Set apic_id during CPU initfn

2015-12-15 Thread Bharata B Rao
On Mon, Dec 14, 2015 at 03:44:06PM -0200, Eduardo Habkost wrote: > On Thu, Dec 10, 2015 at 11:45:43AM +0530, Bharata B Rao wrote: > > Move back the setting of apic_id to instance_init routine (x86_cpu_initfn) > > This is needed to initialize X86 CPUs using generic cpu-package device. > > Could you

Re: [Qemu-devel] [RFC PATCH v0 8/9] target-i386: Set apic_id during CPU initfn

2015-12-14 Thread Eduardo Habkost
On Thu, Dec 10, 2015 at 11:45:43AM +0530, Bharata B Rao wrote: > Move back the setting of apic_id to instance_init routine (x86_cpu_initfn) > This is needed to initialize X86 CPUs using generic cpu-package device. Could you explain where exactly apic_id will be used, to make it necessary to initia

[Qemu-devel] [RFC PATCH v0 8/9] target-i386: Set apic_id during CPU initfn

2015-12-09 Thread Bharata B Rao
Move back the setting of apic_id to instance_init routine (x86_cpu_initfn) This is needed to initialize X86 CPUs using generic cpu-package device. TODO: I am not fully aware of the general direction in which apic_id changes in X86 have evolved and hence not sure if this is indeed aligned with the