Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-29 Thread David Gibson
On Wed, Mar 29, 2017 at 10:04:47AM +0200, Paolo Bonzini wrote: > > > On 29/03/2017 05:04, Alex Williamson wrote: > >>> What if we used this as a prototype: > >>> > >>> int (*get_fd)(IOMMUFdType type, MemoryRegion *iommu); > >>> > >>> And then we defined: > >>> > >>> typedef enum { > >>> SPAPR

Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-29 Thread Paolo Bonzini
On 29/03/2017 05:04, Alex Williamson wrote: >>> What if we used this as a prototype: >>> >>> int (*get_fd)(IOMMUFdType type, MemoryRegion *iommu); >>> >>> And then we defined: >>> >>> typedef enum { >>> SPAPR_IOMMU_TABLE_FD = 0, >>> } IOMMUFdType; >> >> Where do I put this enum definition?

Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread Alexey Kardashevskiy
On 29/03/17 14:35, David Gibson wrote: > On Tue, Mar 28, 2017 at 11:48:29AM -0600, Alex Williamson wrote: >> On Tue, 28 Mar 2017 20:05:28 +1100 >> Alexey Kardashevskiy wrote: >> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> include/exec/memory.h | 2 ++ >>> hw/ppc/spapr_iommu.c | 8 ++

Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread David Gibson
On Tue, Mar 28, 2017 at 11:48:29AM -0600, Alex Williamson wrote: > On Tue, 28 Mar 2017 20:05:28 +1100 > Alexey Kardashevskiy wrote: > > > Signed-off-by: Alexey Kardashevskiy > > --- > > include/exec/memory.h | 2 ++ > > hw/ppc/spapr_iommu.c | 8 > > 2 files changed, 10 insertions(+) >

Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread Alex Williamson
On Wed, 29 Mar 2017 12:41:01 +1100 Alexey Kardashevskiy wrote: > On 29/03/17 04:48, Alex Williamson wrote: > > On Tue, 28 Mar 2017 20:05:28 +1100 > > Alexey Kardashevskiy wrote: > > > >> Signed-off-by: Alexey Kardashevskiy > >> --- > >> include/exec/memory.h | 2 ++ > >> hw/ppc/spapr_iommu.

Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread Alexey Kardashevskiy
On 29/03/17 04:48, Alex Williamson wrote: > On Tue, 28 Mar 2017 20:05:28 +1100 > Alexey Kardashevskiy wrote: > >> Signed-off-by: Alexey Kardashevskiy >> --- >> include/exec/memory.h | 2 ++ >> hw/ppc/spapr_iommu.c | 8 >> 2 files changed, 10 insertions(+) >> >> diff --git a/include/ex

Re: [Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread Alex Williamson
On Tue, 28 Mar 2017 20:05:28 +1100 Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy > --- > include/exec/memory.h | 2 ++ > hw/ppc/spapr_iommu.c | 8 > 2 files changed, 10 insertions(+) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index e39256ad03

[Qemu-devel] [RFC PATCH qemu 1/3] memory: Add get_fd() hook for IOMMU MR

2017-03-28 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- include/exec/memory.h | 2 ++ hw/ppc/spapr_iommu.c | 8 2 files changed, 10 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index e39256ad03..925c10b35b 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1