Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-07-07 Thread Frederic Konrad
On 07/07/2015 14:33, Alex Bennée wrote: Frederic Konrad writes: On 26/06/2015 16:56, Jan Kiszka wrote: On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-07-07 Thread Alex Bennée
Frederic Konrad writes: > On 26/06/2015 16:56, Jan Kiszka wrote: >> On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: >>> From: Jan Kiszka >>> >>> This finally allows TCG to benefit from the iothread introduction: Drop >>> the global mutex while running pure TCG CPU code. Reacquire the lock

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-06-26 Thread Frederic Konrad
On 26/06/2015 17:42, Jan Kiszka wrote: On 2015-06-26 17:36, Frederic Konrad wrote: On 26/06/2015 16:56, Jan Kiszka wrote: On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while runn

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-06-26 Thread Jan Kiszka
On 2015-06-26 17:36, Frederic Konrad wrote: > On 26/06/2015 16:56, Jan Kiszka wrote: >> On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: >>> From: Jan Kiszka >>> >>> This finally allows TCG to benefit from the iothread introduction: Drop >>> the global mutex while running pure TCG CPU code. R

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-06-26 Thread Frederic Konrad
On 26/06/2015 16:56, Jan Kiszka wrote: On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU code. Reacquire the lock when entering MMIO or PIO emulation, or whe

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-06-26 Thread Paolo Bonzini
On 26/06/2015 16:56, Jan Kiszka wrote: >> > +/* >> > + * Some device's reset needs to grab the global_mutex. So just >> > release it >> > + * here. > That's a property newly introduced by the patch, or how does this > happen? In turn, are all reset handlers now fine to be called outs

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-06-26 Thread Jan Kiszka
On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: > From: Jan Kiszka > > This finally allows TCG to benefit from the iothread introduction: Drop > the global mutex while running pure TCG CPU code. Reacquire the lock > when entering MMIO or PIO emulation, or when leaving the TCG loop. > > We

[Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-06-26 Thread fred . konrad
From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU code. Reacquire the lock when entering MMIO or PIO emulation, or when leaving the TCG loop. We have to revert a few optimization for the current TCG threading mode