Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Paolo Bonzini
On 26/03/2015 08:23, Wen Congyang wrote: >>> >> Hmm, we need to use backup API in block.c, and block.o will >>> >> be used by qemu-img which doesn't use common-obj. >> > >> > I see. How about adding the referenced functions to stubs/? > Good idea. I will try it. Even better would be to move the

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:18 PM, Fam Zheng wrote: > On Thu, 03/26 15:14, Wen Congyang wrote: >> On 03/26/2015 03:07 PM, Fam Zheng wrote: >>> On Wed, 03/25 17:36, Wen Congyang wrote: When opening BDS, we need to create backup jobs for image-fleecing. >>> >>> How does this commit message relate to t

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Fam Zheng
On Thu, 03/26 15:14, Wen Congyang wrote: > On 03/26/2015 03:07 PM, Fam Zheng wrote: > > On Wed, 03/25 17:36, Wen Congyang wrote: > >> When opening BDS, we need to create backup jobs for > >> image-fleecing. > > > > How does this commit message relate to the Makefile change? > > Hmm, we need to us

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Fam Zheng
On Wed, 03/25 17:36, Wen Congyang wrote: > When opening BDS, we need to create backup jobs for > image-fleecing. How does this commit message relate to the Makefile change? > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Jeff Cody > --- > block/

Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-26 Thread Wen Congyang
On 03/26/2015 03:07 PM, Fam Zheng wrote: > On Wed, 03/25 17:36, Wen Congyang wrote: >> When opening BDS, we need to create backup jobs for >> image-fleecing. > > How does this commit message relate to the Makefile change? Hmm, we need to use backup API in block.c, and block.o will be used by qemu

[Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

2015-03-25 Thread Wen Congyang
When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Jeff Cody --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Makefile.objs b/block/Makefile.ob