Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-12 Thread Igor Mammedov
On Fri, 12 Apr 2019 13:44:07 +0800 Wei Yang wrote: > On Tue, Apr 09, 2019 at 04:54:15PM +0200, Igor Mammedov wrote: > >> > >> Let's see a normal hotplug case first. > >> > >> I did one test to see the how a guest with hot-plug cpu migrate to > >> destination. It looks the migration fa

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-11 Thread Wei Yang
On Tue, Apr 09, 2019 at 04:54:15PM +0200, Igor Mammedov wrote: >> >> Let's see a normal hotplug case first. >> >> I did one test to see the how a guest with hot-plug cpu migrate to >> destination. It looks the migration fails if I just do hot-plug at >> source. So I have to do hot-p

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-09 Thread Igor Mammedov
On Fri, 5 Apr 2019 16:55:30 +0800 Wei Yang wrote: > On Tue, Apr 02, 2019 at 08:15:12AM +0200, Igor Mammedov wrote: > >On Tue, 2 Apr 2019 11:53:43 +0800 > >Wei Yang wrote: > > > > > >> The migration infrastructure has several SaveStateEntry to help migrate > >> different elements. The one with

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-05 Thread Wei Yang
On Tue, Apr 02, 2019 at 08:15:12AM +0200, Igor Mammedov wrote: >On Tue, 2 Apr 2019 11:53:43 +0800 >Wei Yang wrote: > > >> The migration infrastructure has several SaveStateEntry to help migrate >> different elements. The one with name "ram" take charge of RAMBlock. So this >> SaveStateEntry and i

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-01 Thread Igor Mammedov
On Tue, 2 Apr 2019 11:53:43 +0800 Wei Yang wrote: > On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: > >On Wed, 13 Mar 2019 13:33:59 + > >Wei Yang wrote: > > > >> > >> I am lost at this place. > >> > >> sig is a part of ACPI table header, you mean the sig is not necessary t

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-01 Thread Wei Yang
On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 13:33:59 + >Wei Yang wrote: > >> >> I am lost at this place. >> >> sig is a part of ACPI table header, you mean the sig is not necessary to >> be set in ACPI table header? >> >> "skip table generation" means

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-20 Thread Wei Yang
On Sat, Mar 16, 2019 at 10:31:24AM +, Wei Yang wrote: >On Thu, Mar 14, 2019 at 10:18:30AM +0100, Igor Mammedov wrote: >>On Wed, 13 Mar 2019 21:31:37 + >>Wei Yang wrote: >> >>> On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >>> >On Wed, 13 Mar 2019 13:33:59 + >>> >Wei Ya

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-16 Thread Wei Yang
On Thu, Mar 14, 2019 at 10:18:30AM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 21:31:37 + >Wei Yang wrote: > >> On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >> >On Wed, 13 Mar 2019 13:33:59 + >> >Wei Yang wrote: >> > >> >> On Wed, Mar 13, 2019 at 01:23:00PM +0100,

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-14 Thread Wei Yang
On Thu, Mar 14, 2019 at 10:18:30AM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 21:31:37 + >Wei Yang wrote: > >> On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >> >On Wed, 13 Mar 2019 13:33:59 + >> >Wei Yang wrote: >> > >> >> On Wed, Mar 13, 2019 at 01:23:00PM +0100,

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-14 Thread Igor Mammedov
On Wed, 13 Mar 2019 21:31:37 + Wei Yang wrote: > On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: > >On Wed, 13 Mar 2019 13:33:59 + > >Wei Yang wrote: > > > >> On Wed, Mar 13, 2019 at 01:23:00PM +0100, Igor Mammedov wrote: > >> >On Wed, 13 Mar 2019 12:42:53 +0800 > >> >

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-13 Thread Wei Yang
On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 13:33:59 + >Wei Yang wrote: > >> On Wed, Mar 13, 2019 at 01:23:00PM +0100, Igor Mammedov wrote: >> >On Wed, 13 Mar 2019 12:42:53 +0800 >> >Wei Yang wrote: >> > >> >> Now we have two identical build_mcfg func

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-13 Thread Igor Mammedov
On Wed, 13 Mar 2019 13:33:59 + Wei Yang wrote: > On Wed, Mar 13, 2019 at 01:23:00PM +0100, Igor Mammedov wrote: > >On Wed, 13 Mar 2019 12:42:53 +0800 > >Wei Yang wrote: > > > >> Now we have two identical build_mcfg function. > >> > >> Extract them to aml-build.c. > >> > >> Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-13 Thread Wei Yang
On Wed, Mar 13, 2019 at 01:23:00PM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 12:42:53 +0800 >Wei Yang wrote: > >> Now we have two identical build_mcfg function. >> >> Extract them to aml-build.c. >> >> Signed-off-by: Wei Yang >> --- >> hw/acpi/aml-build.c | 30 ++

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-13 Thread Igor Mammedov
On Wed, 13 Mar 2019 12:42:53 +0800 Wei Yang wrote: > Now we have two identical build_mcfg function. > > Extract them to aml-build.c. > > Signed-off-by: Wei Yang > --- > hw/acpi/aml-build.c | 30 ++ > hw/arm/virt-acpi-build.c| 16 > hw/i

[Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-12 Thread Wei Yang
Now we have two identical build_mcfg function. Extract them to aml-build.c. Signed-off-by: Wei Yang --- hw/acpi/aml-build.c | 30 ++ hw/arm/virt-acpi-build.c| 16 hw/i386/acpi-build.c| 31 +-- include/h