Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test

2018-02-07 Thread Roman Kagan
On Wed, Feb 07, 2018 at 12:15:50PM +0100, Paolo Bonzini wrote: > On 06/02/2018 21:30, Roman Kagan wrote: > > +if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) { > > +g_printerr("Hyper-V / VMBus are only available on x86\n"); > > +exit(EXIT_FAILURE); > > +} > > This shoul

Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test

2018-02-07 Thread Paolo Bonzini
On 06/02/2018 21:30, Roman Kagan wrote: > +if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) { > +g_printerr("Hyper-V / VMBus are only available on x86\n"); > +exit(EXIT_FAILURE); > +} This shouldn't be needed. > + > +if (access("/dev/kvm", R_OK | W_OK)) { Maybe try

[Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test

2018-02-06 Thread Roman Kagan
It's trivial and tests only a tiny fraction of the relevant code, but it's better than nothing. Signed-off-by: Roman Kagan --- tests/hv-scsi-test.c | 57 ++ tests/Makefile.include | 3 +++ 2 files changed, 60 insertions(+) create mode 100644 te