Re: [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller

2018-02-07 Thread Roman Kagan
On Wed, Feb 07, 2018 at 12:11:50PM +0100, Paolo Bonzini wrote: > On 06/02/2018 21:30, Roman Kagan wrote: > > +blk_io_plug(d->conf.blk); > > +if (scsi_req_enqueue(sreq)) { > > +scsi_req_continue(sreq); > > +} > > +blk_io_unplug(d->conf.blk); > > Is plug/unplug really useful?

Re: [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller

2018-02-07 Thread Denis V. Lunev
On 02/07/2018 02:11 PM, Paolo Bonzini wrote: > On 06/02/2018 21:30, Roman Kagan wrote: >> +blk_io_plug(d->conf.blk); >> +if (scsi_req_enqueue(sreq)) { >> +scsi_req_continue(sreq); >> +} >> +blk_io_unplug(d->conf.blk); > Is plug/unplug really useful? > > Paolo good point. her

Re: [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller

2018-02-07 Thread Paolo Bonzini
On 06/02/2018 21:30, Roman Kagan wrote: > +blk_io_plug(d->conf.blk); > +if (scsi_req_enqueue(sreq)) { > +scsi_req_continue(sreq); > +} > +blk_io_unplug(d->conf.blk); Is plug/unplug really useful? Paolo

[Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller

2018-02-06 Thread Roman Kagan
Add an implementation of Hyper-V/VMBus SCSI controller. Kudos to Evgeny Yakovlev (formerly eyakov...@virtuozzo.com) for research and prototyping. Signed-off-by: Roman Kagan --- hw/scsi/hv-scsi.c | 398 ++ hw/scsi/Makefile.objs | 2 + hw/scsi