Re: [Qemu-devel] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments

2016-11-11 Thread Alberto Garcia
On Thu 10 Nov 2016 06:19:03 PM CET, Kevin Wolf wrote: > There is no point in passing the value of bs->opaque in order to > overwrite it with itself. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments

2016-11-11 Thread Paolo Bonzini
On 10/11/2016 18:19, Kevin Wolf wrote: > There is no point in passing the value of bs->opaque in order to > overwrite it with itself. > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/block/quorum.c b/block/q

Re: [Qemu-devel] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments

2016-11-10 Thread Eric Blake
On 11/10/2016 11:19 AM, Kevin Wolf wrote: > There is no point in passing the value of bs->opaque in order to > overwrite it with itself. > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Bl

[Qemu-devel] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments

2016-11-10 Thread Kevin Wolf
There is no point in passing the value of bs->opaque in order to overwrite it with itself. Signed-off-by: Kevin Wolf --- block/quorum.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index d122299..dfa9fd3 100644 --- a/block/quorum.c