Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-15 Thread Paolo Bonzini
On 15/07/19 14:36, Yury Kotov wrote: > Sorry, perhaps I was not accurate enough. > > To fix the bug I changed the logic of cpu_throttle_thread() function. > Before this function called qemu_mutex_(un)lock_iothread which encapsulates > work with qemu_global_mutex. > > Now, this calls qemu_cond_tim

Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-15 Thread Yury Kotov
15.07.2019, 14:00, "Paolo Bonzini" : > On 15/07/19 11:40, Yury Kotov wrote: >>  Hi, >> >>  10.07.2019, 12:26, "Yury Kotov" : >>>  Throttling thread sleeps in VCPU thread. For high throttle percentage >>>  this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. >>>  vm_stop() kicks all V

Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-15 Thread Paolo Bonzini
On 15/07/19 11:40, Yury Kotov wrote: > Hi, > > 10.07.2019, 12:26, "Yury Kotov" : >> Throttling thread sleeps in VCPU thread. For high throttle percentage >> this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. >> vm_stop() kicks all VCPUs and waits for them. It's called at the end o

Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-15 Thread Yury Kotov
Hi, 10.07.2019, 12:26, "Yury Kotov" : > Throttling thread sleeps in VCPU thread. For high throttle percentage > this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. > vm_stop() kicks all VCPUs and waits for them. It's called at the end of > migration and because of the long sleep th

[Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-10 Thread Yury Kotov
Throttling thread sleeps in VCPU thread. For high throttle percentage this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. vm_stop() kicks all VCPUs and waits for them. It's called at the end of migration and because of the long sleep the migration downtime might be more than 100ms e