Re: [Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support

2013-12-03 Thread Gerd Hoffmann
On Mo, 2013-12-02 at 14:00 -0500, John Baboval wrote: > I'm not sure this is correct. Generally when the display gets rotated, > the input device coordinates do not, and the in-guest code handles the math. This just mimics what kbd_mouse_event() does today. I guess there is a reason this code wa

Re: [Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support

2013-12-02 Thread John Baboval
I'm not sure this is correct. Generally when the display gets rotated, the input device coordinates do not, and the in-guest code handles the math. On 11/28/2013 09:30 AM, Gerd Hoffmann wrote: Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absol

[Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support

2013-11-28 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --- ui/input.c | 33 ++