Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-07-04 Thread Halil Pasic
On 07/04/2017 08:42 AM, Markus Armbruster wrote: > Halil Pasic writes: > >> On 07/03/2017 03:52 PM, Markus Armbruster wrote: >>> Halil Pasic writes: >>> On 06/30/2017 04:54 PM, Eric Blake wrote: > On 06/30/2017 09:41 AM, Halil Pasic wrote: [..] >>> If we have errors that can't be adeq

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-07-03 Thread Markus Armbruster
Halil Pasic writes: > On 07/03/2017 03:52 PM, Markus Armbruster wrote: >> Halil Pasic writes: >> >>> On 06/30/2017 04:54 PM, Eric Blake wrote: On 06/30/2017 09:41 AM, Halil Pasic wrote: >>> 'This' basically boils down to the question and >>> 'Why aren't hints reported in QMP contex

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-07-03 Thread Halil Pasic
On 07/03/2017 03:52 PM, Markus Armbruster wrote: > Halil Pasic writes: > >> On 06/30/2017 04:54 PM, Eric Blake wrote: >>> On 06/30/2017 09:41 AM, Halil Pasic wrote: >> 'This' basically boils down to the question and >> 'Why aren't hints reported in QMP context?' > > QMP is suppo

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-07-03 Thread Markus Armbruster
Halil Pasic writes: > On 06/30/2017 04:54 PM, Eric Blake wrote: >> On 06/30/2017 09:41 AM, Halil Pasic wrote: > 'This' basically boils down to the question and > 'Why aren't hints reported in QMP context?' QMP is supposed to be machine-parseable. Hints are supposed to be h

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-30 Thread Halil Pasic
On 06/30/2017 04:54 PM, Eric Blake wrote: > On 06/30/2017 09:41 AM, Halil Pasic wrote: 'This' basically boils down to the question and 'Why aren't hints reported in QMP context?' >>> >>> QMP is supposed to be machine-parseable. Hints are supposed to be >>> human-readable. If you have a

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-30 Thread Eric Blake
On 06/30/2017 09:41 AM, Halil Pasic wrote: >>> 'This' basically boils down to the question and >>> 'Why aren't hints reported in QMP context?' >> >> QMP is supposed to be machine-parseable. Hints are supposed to be >> human-readable. If you have a machine managing the monitor, the hint >> adds not

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-30 Thread Halil Pasic
On 06/29/2017 09:04 PM, Eric Blake wrote: > On 06/14/2017 08:51 AM, Halil Pasic wrote: > > [apologies for the delayed response, and also adding Markus] > No problem. Many thanks for the effort. I see I've ended up with a lengthy email. A disclaimer before I start: No strong opinions here. Thin

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-29 Thread Eric Blake
On 06/14/2017 08:51 AM, Halil Pasic wrote: [apologies for the delayed response, and also adding Markus] >> >> One reason I choose error_report_err is to be consistent about hint >> reporting (the other one is that was what Connie suggested). I do >> not understand why do we omit hints if QMP, bu

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-22 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 06/22/2017 10:22 AM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 06/08/2017 01:05 PM, Halil Pasic wrote: > >>> > >>> > >>> On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote: >

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-22 Thread Halil Pasic
On 06/22/2017 10:22 AM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 06/08/2017 01:05 PM, Halil Pasic wrote: >>> >>> >>> On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote: * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > In some cases a

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-22 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 06/08/2017 01:05 PM, Halil Pasic wrote: > > > > > > On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote: > >> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >>> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug >

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-14 Thread Halil Pasic
On 06/08/2017 01:05 PM, Halil Pasic wrote: > > > On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote: >> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >>> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug >>> (it's actually the best we can do). Especially in these cases

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-08 Thread Halil Pasic
On 06/07/2017 11:51 AM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug >> (it's actually the best we can do). Especially in these cases a verbose >> error message is required. >> >> Let's i

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-07 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug > (it's actually the best we can do). Especially in these cases a verbose > error message is required. > > Let's introduce infrastructure for specifying a error hint to be used

[Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-06 Thread Halil Pasic
In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug (it's actually the best we can do). Especially in these cases a verbose error message is required. Let's introduce infrastructure for specifying a error hint to be used if equal check fails. Signed-off-by: Halil Pasic --- Ma