Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-04 Thread kwangwoo....@sk.com
aydell > Cc: Xiao Guangrong; Eduardo Habkost; Michael S. Tsirkin; QEMU Developers; > 정우석(CHUNG WOO SUK) MS SW; > qemu-arm; Shannon Zhao; Shannon Zhao; Paolo Bonzini; 김현철(KIM HYUNCHUL) MS SW; > 이광우(LEE KWANGWOO) MS > SW; Richard Henderson > Subject: Re: [Qemu-devel] [RFC PATCH 1

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-02 Thread Igor Mammedov
On Tue, 2 Aug 2016 08:59:46 +0100 Peter Maydell wrote: > On 1 August 2016 at 10:14, Igor Mammedov wrote: > > On Mon, 1 Aug 2016 09:13:34 +0100 > > Peter Maydell wrote: > >> On 1 August 2016 at 08:46, Igor Mammedov wrote: > >> > Base alignment comes from max supported hugepage size, > >>

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-02 Thread Peter Maydell
On 1 August 2016 at 10:14, Igor Mammedov wrote: > On Mon, 1 Aug 2016 09:13:34 +0100 > Peter Maydell wrote: >> On 1 August 2016 at 08:46, Igor Mammedov wrote: >> > Base alignment comes from max supported hugepage size, >> >> Max hugepage size for any host? (if so, should be defined >> in a common

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread kwangwoo....@sk.com
Hi, Thank you for the alignment information and discussion, Igor and Peter! I'll try to find out proper alignment by looking at the codes. Best Regards, Kwangwoo Lee > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Monday, August 01, 2016 6:15 PM > To: Pet

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread Igor Mammedov
On Mon, 1 Aug 2016 09:13:34 +0100 Peter Maydell wrote: > On 1 August 2016 at 08:46, Igor Mammedov wrote: > > On Mon, 1 Aug 2016 00:35:35 + > > "kwangwoo@sk.com" wrote: > > >> > > +/* 1GB alignment for hotplug memory region */ > >> > > +#define ARCH_VIRT_HOTPLUG_MEM_ALIGN (1ULL << 30)

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread Peter Maydell
On 1 August 2016 at 08:46, Igor Mammedov wrote: > On Mon, 1 Aug 2016 00:35:35 + > "kwangwoo@sk.com" wrote: >> > > +/* 1GB alignment for hotplug memory region */ >> > > +#define ARCH_VIRT_HOTPLUG_MEM_ALIGN (1ULL << 30) >> > >> > Where does the 1GB alignment come from? Why do we need 1GB >

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread Igor Mammedov
On Mon, 1 Aug 2016 00:35:35 + "kwangwoo@sk.com" wrote: > Hi Peter, > > Thanks a lot for your comments! I answered in line below. > > > -Original Message- > > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > Sent: Saturday, July 30, 2016 3:10 AM > > To: 이광우(LEE KWANGWOO)

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-07-31 Thread kwangwoo....@sk.com
Hi Peter, Thanks a lot for your comments! I answered in line below. > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, July 30, 2016 3:10 AM > To: 이광우(LEE KWANGWOO) MS SW > Cc: Xiao Guangrong; Michael S. Tsirkin; Igor Mammedov; Paolo Bonzini; Ri

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-07-29 Thread Peter Maydell
On 20 July 2016 at 01:49, Kwangwoo Lee wrote: > Add hotplug memory feature on aarch64 virt platfom. This patch is > required to emulate a DIMM type memory like NVDIMM. > > Signed-off-by: Kwangwoo Lee > --- > default-configs/aarch64-softmmu.mak | 1 + > hw/arm/virt.c | 110

[Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-07-19 Thread Kwangwoo Lee
Add hotplug memory feature on aarch64 virt platfom. This patch is required to emulate a DIMM type memory like NVDIMM. Signed-off-by: Kwangwoo Lee --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/virt.c | 110 include/hw/arm/virt.h