Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

2017-02-07 Thread Peter Maydell
On 25 January 2017 at 07:38, Alessandro Di Federico wrote: > On Tue, 24 Jan 2017 11:18:07 + > Peter Maydell wrote: >> If we had more active testing of bsd-user I'd be a bit keener >> about removing some of the code duplication. > > Currently, the code looks exactly the same to me. If we don't

Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

2017-01-24 Thread Alessandro Di Federico
On Tue, 24 Jan 2017 11:18:07 + Peter Maydell wrote: > So my issue with this is that currently linux-user is pretty > well maintained and tested, but bsd-user is basically unmaintained > and not even compile tested. I can say it compiles. I've tried to build it on FreeBSD 11. Didn't tested i

Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

2017-01-24 Thread Alessandro Di Federico
On Tue, 24 Jan 2017 10:10:08 + Marc-André Lureau wrote: > > Looks good. Probably worth to mention that the main difference is in > commit 658f2dc970996d547a641b5685e384ebe6f2648e not being applied to > bsd-user. > Yeah, I'll rebase my next patches on master. My only doubt about this patch

Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

2017-01-24 Thread Peter Maydell
On 21 January 2017 at 08:45, Alessandro Di Federico wrote: > A quite large part of {linux,bsd}-user/qemu.h is shared, this patch > introduces qemu-user-common.h which factors it out. This shared part is > also the bare minimum required to build a linux-user-like target, and, > in particular, it wi

Re: [Qemu-devel] [RFC PATCH 1/3] Factor out {linux, bsd}-user/qemu.h

2017-01-24 Thread Marc-André Lureau
Hi On Sat, Jan 21, 2017 at 12:46 PM Alessandro Di Federico < ale+q...@clearmind.me> wrote: A quite large part of {linux,bsd}-user/qemu.h is shared, this patch introduces qemu-user-common.h which factors it out. This shared part is also the bare minimum required to build a linux-user-like target,

[Qemu-devel] [RFC PATCH 1/3] Factor out {linux,bsd}-user/qemu.h

2017-01-21 Thread Alessandro Di Federico
A quite large part of {linux,bsd}-user/qemu.h is shared, this patch introduces qemu-user-common.h which factors it out. This shared part is also the bare minimum required to build a linux-user-like target, and, in particular, it will be useful for the libtcg targets. --- bsd-user/qemu.h| 193 +