Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Eduardo Habkost
On Mon, Nov 12, 2018 at 07:52:28PM +0100, Philippe Mathieu-Daudé wrote: > On Mon, Nov 12, 2018 at 6:03 PM Eduardo Habkost wrote: > > On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > > > Python internal representation is signed, so unsigned values > > > bigger than 31-bit a

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Richard Henderson
On 11/12/18 7:52 PM, Philippe Mathieu-Daudé wrote: > So the fix is rather: > > -- >8 -- > diff --git a/scripts/decodetree.py b/scripts/decodetree.py > @@ -916,7 +916,7 @@ class Tree: > > def build_tree(pats, outerbits, outermask): > # Find the intersection of all remaining fixedmask. > -

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Philippe Mathieu-Daudé
> On Mon, Nov 12, 2018 at 6:03 PM Eduardo Habkost wrote: > > On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > > > Python internal representation is signed, so unsigned values > > > bigger than 31-bit are interpreted as signed (and printed with > > > a '-' signed). > > > Ma

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Philippe Mathieu-Daudé
On Mon, Nov 12, 2018 at 6:03 PM Eduardo Habkost wrote: > On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > > Python internal representation is signed, so unsigned values > > bigger than 31-bit are interpreted as signed (and printed with > > a '-' signed). > > Mask out to fo

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Eduardo Habkost
On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > Python internal representation is signed, so unsigned values > bigger than 31-bit are interpreted as signed (and printed with > a '-' signed). > Mask out to force unsigned values. I don't understand this commit description.

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Philippe Mathieu-Daudé
On Mon, Nov 12, 2018 at 9:20 AM Richard Henderson wrote: > On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > > Python internal representation is signed, so unsigned values > > bigger than 31-bit are interpreted as signed (and printed with > > a '-' signed). > > Mask out to force unsigned value

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Richard Henderson
On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > Python internal representation is signed, so unsigned values > bigger than 31-bit are interpreted as signed (and printed with > a '-' signed). > Mask out to force unsigned values. > > Signed-off-by: Philippe Mathieu-Daudé > --- > TODO: display

[Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-11 Thread Philippe Mathieu-Daudé
Python internal representation is signed, so unsigned values bigger than 31-bit are interpreted as signed (and printed with a '-' signed). Mask out to force unsigned values. Signed-off-by: Philippe Mathieu-Daudé --- TODO: display error encountered: case 0x-1: --- scripts/decodetr