Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Michael S. Tsirkin
On Tue, Sep 16, 2014 at 10:23:03AM -0700, Peter Maydell wrote: > On 16 September 2014 09:57, Michael S. Tsirkin wrote: > > Could you pls tell me whether my patch works, in your testing? > > My box which had such an old glib seems to be dead. > > Can you give me a Subject: line or a URL in patchwo

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Peter Maydell
On 16 September 2014 09:57, Michael S. Tsirkin wrote: > Could you pls tell me whether my patch works, in your testing? > My box which had such an old glib seems to be dead. Can you give me a Subject: line or a URL in patchwork, please? (I can't conveniently search by message-id.) thanks -- PMM

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Michael S. Tsirkin
On Tue, Sep 16, 2014 at 06:23:29PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 18:20, Peter Maydell ha scritto: > >> > - bumping the minimum required version from 2.12 to 2.16. I suggest > >> > bumping to the currently required version for Windows, which is 2.20 > >> > (released March 2009). > > T

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Michael S. Tsirkin
On Tue, Sep 16, 2014 at 09:45:03AM -0700, Peter Maydell wrote: > On 16 September 2014 09:33, Paolo Bonzini wrote: > > Il 16/09/2014 18:28, Peter Maydell ha scritto: > >>> > Though you would just drop support for "make check" on RHEL5. Even > >>> > "make -k check" would roughly work. > >> Can't we

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Peter Maydell
On 16 September 2014 09:33, Paolo Bonzini wrote: > Il 16/09/2014 18:28, Peter Maydell ha scritto: >>> > Though you would just drop support for "make check" on RHEL5. Even >>> > "make -k check" would roughly work. >> Can't we just put in the makefile and configure magic to skip >> the test if the

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Michael S. Tsirkin
On Tue, Sep 16, 2014 at 09:28:03AM -0700, Peter Maydell wrote: > On 16 September 2014 09:23, Paolo Bonzini wrote: > > Il 16/09/2014 18:20, Peter Maydell ha scritto: > >>> > - bumping the minimum required version from 2.12 to 2.16. I suggest > >>> > bumping to the currently required version for Wi

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 18:28, Peter Maydell ha scritto: >> > Though you would just drop support for "make check" on RHEL5. Even >> > "make -k check" would roughly work. > Can't we just put in the makefile and configure magic to skip > the test if the glib version is too old for it? Yes, that's what Michae

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Peter Maydell
On 16 September 2014 09:23, Paolo Bonzini wrote: > Il 16/09/2014 18:20, Peter Maydell ha scritto: >>> > - bumping the minimum required version from 2.12 to 2.16. I suggest >>> > bumping to the currently required version for Windows, which is 2.20 >>> > (released March 2009). >> The commit message

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 18:20, Peter Maydell ha scritto: >> > - bumping the minimum required version from 2.12 to 2.16. I suggest >> > bumping to the currently required version for Windows, which is 2.20 >> > (released March 2009). > The commit message for a52d28afb suggests that this bump would be > droppi

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Peter Maydell
On 16 September 2014 08:43, Paolo Bonzini wrote: > Glib recently introduced a robust way to run tests in a subprocess, > which is used in test-qdev-global-props. However, we would like > to have the same tests run with older versions of glib, and the > older fork-based mechanisms works well enoug

Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Michael S. Tsirkin
On Tue, Sep 16, 2014 at 05:43:24PM +0200, Paolo Bonzini wrote: > Glib recently introduced a robust way to run tests in a subprocess, > which is used in test-qdev-global-props. However, we would like > to have the same tests run with older versions of glib, and the > older fork-based mechanisms wor

[Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38

2014-09-16 Thread Paolo Bonzini
Glib recently introduced a robust way to run tests in a subprocess, which is used in test-qdev-global-props. However, we would like to have the same tests run with older versions of glib, and the older fork-based mechanisms works well enough. This still requires: - bumping the minimum required v