Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-28 Thread Kirill Batuzov
On 28.03.2014 20:34, Alex Bennée wrote: @@ -2575,6 +2579,8 @@ static inline int tcg_gen_code_common(TCGContext *s, uint64_t target_pc, the_end: /* Generate TB finalization at the end of block */ tcg_out_tb_finalize(s); + +tcg_write_perfmap(gen_code_buf, s->code_ptr - gen_code

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-28 Thread Alex Bennée
Kirill Batuzov writes: > On Thu, 27 Mar 2014, alex.ben...@linaro.org wrote: > >> From: Alex Bennée >> >> This allows the perf tool to map samples to each individual translation >> block. This could be expanded for user space but currently it gives >> enough information to find any hotblocks by

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-28 Thread Richard Henderson
On 03/28/2014 04:12 AM, Alex Bennée wrote: > I've had a brief poke around the TCG profiling and seen it track > generation cost. Do we have any hotblock tracking in the built-in profiler? No. r~

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-28 Thread Richard Henderson
On 03/28/2014 04:12 AM, Alex Bennée wrote: > Do we have a format macro for target_ulong? TCG_PRIlx or TCG_PRIld. r~

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-28 Thread Kirill Batuzov
On Thu, 27 Mar 2014, alex.ben...@linaro.org wrote: > From: Alex Bennée > > This allows the perf tool to map samples to each individual translation > block. This could be expanded for user space but currently it gives > enough information to find any hotblocks by other means. I'm in favor of t

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-28 Thread Alex Bennée
Richard Henderson writes: > On 03/27/2014 09:37 AM, alex.ben...@linaro.org wrote: >> From: Alex Bennée >> >> This allows the perf tool to map samples to each individual translation >> block. This could be expanded for user space but currently it gives >> enough information to find any hotblock

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-27 Thread Richard Henderson
On 03/27/2014 09:37 AM, alex.ben...@linaro.org wrote: > From: Alex Bennée > > This allows the perf tool to map samples to each individual translation > block. This could be expanded for user space but currently it gives > enough information to find any hotblocks by other means. Plausible, I supp

[Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-27 Thread alex . bennee
From: Alex Bennée This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. --- qemu-options.hx | 10 ++ tcg/tcg.c | 21 +