On 07/22/2013 04:30 PM, Paolo Bonzini wrote:
> Il 22/07/2013 03:04, Benjamin Herrenschmidt ha scritto:
>> The free_request callback
>> is not directly "linked" to task management though it happens to only
>> be called in that case. It's a pre-requisite to task management, make it
>> a separate patc
On Mon, 2013-07-22 at 08:30 +0200, Paolo Bonzini wrote:
> I suggest you check in the relevant part of the vscsi spec how you are
> supposed to send back errors ("FUNCTION REJECTED", "INCORRECT LUN").
> Once you do that, implementing the "query" TMFs is trivial.
The vscsi spec is just the transport
Il 22/07/2013 03:04, Benjamin Herrenschmidt ha scritto:
> The free_request callback
> is not directly "linked" to task management though it happens to only
> be called in that case. It's a pre-requisite to task management, make it
> a separate patch.
Ben is right, in fact I'm not sure why you need
On Mon, 2013-07-22 at 10:57 +1000, Alexey Kardashevskiy wrote:
> On 07/22/2013 10:23 AM, Benjamin Herrenschmidt wrote:
> > On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
> >> May be. But there was no way to get this callback called till I started
> >> calling scsi_req_cancel in this
On 07/22/2013 10:23 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
>> May be. But there was no way to get this callback called till I started
>> calling scsi_req_cancel in this patch so I would not split.
>
> You probably still should. The smalle
On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
> May be. But there was no way to get this callback called till I started
> calling scsi_req_cancel in this patch so I would not split.
You probably still should. The smaller each individual patch, the better
(in part because that make
On 07/22/2013 07:34 AM, Benjamin Herrenschmidt wrote:
> On Sun, 2013-07-21 at 20:04 +1000, Alexey Kardashevskiy wrote:
>> At the moment the guest kernel issues two types of task management requests
>> to the hypervisor - task about and lun reset. This adds handling for
>> these tasks.
>
> My worry
Il 21/07/2013 23:34, Benjamin Herrenschmidt ha scritto:
> On Sun, 2013-07-21 at 20:04 +1000, Alexey Kardashevskiy wrote:
>> At the moment the guest kernel issues two types of task management requests
>> to the hypervisor - task about and lun reset. This adds handling for
>> these tasks.
>
> My wor
On Sun, 2013-07-21 at 20:04 +1000, Alexey Kardashevskiy wrote:
> At the moment the guest kernel issues two types of task management requests
> to the hypervisor - task about and lun reset. This adds handling for
> these tasks.
My worry is that the specification calls for all of them, and we don't
At the moment the guest kernel issues two types of task management requests
to the hypervisor - task about and lun reset. This adds handling for
these tasks.
Signed-off-by: Alexey Kardashevskiy
---
I still do not have really good test to test the task management, any working
ideas? :)
This is
10 matches
Mail list logo
