On 2018-08-20 08:38, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 2018-08-16 08:40, Markus Armbruster wrote:
[...]
>> (And technically you need a string filename to point to when doing
>> block-commit (Kevin sent patches to remedy this, though), so that could
>> be called an application
Max Reitz writes:
> On 2018-08-16 08:40, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>>> On 2018-08-15 10:12, Markus Armbruster wrote:
Max Reitz writes:
>>>
>>> [...]
>>>
> To me personally the issue is that if you can specify a plain filename,
> bdrv_refresh_filename() shoul
On 2018-08-16 08:40, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 2018-08-15 10:12, Markus Armbruster wrote:
>>> Max Reitz writes:
>>
>> [...]
>>
To me personally the issue is that if you can specify a plain filename,
bdrv_refresh_filename() should give you that plain filename
Max Reitz writes:
> On 2018-08-15 10:12, Markus Armbruster wrote:
>> Max Reitz writes:
>
> [...]
>
>>> To me personally the issue is that if you can specify a plain filename,
>>> bdrv_refresh_filename() should give you that plain filename back. So
>>> rbd's implementation of that is lacking. W
Jeff Cody writes:
> On Wed, Aug 15, 2018 at 10:12:12AM +0200, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>> > On 2018-07-28 06:32, Jeff Cody wrote:
>> >> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
>> >>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
On 2018-08-15 10:12, Markus Armbruster wrote:
> Max Reitz writes:
[...]
>> To me personally the issue is that if you can specify a plain filename,
>> bdrv_refresh_filename() should give you that plain filename back. So
>> rbd's implementation of that is lacking. Well, it just doesn't exist.
>
On Wed, Aug 15, 2018 at 10:12:12AM +0200, Markus Armbruster wrote:
> Max Reitz writes:
>
> > On 2018-07-28 06:32, Jeff Cody wrote:
> >> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
> >>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> On 07/25/2018 10:10
Max Reitz writes:
> On 2018-07-28 06:32, Jeff Cody wrote:
>> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
>>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> qemu_rbd_parse_filename() builds a keypairs
Jeff Cody writes:
> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
>> On 07/25/2018 10:10 AM, Markus Armbruster wrote:
>> >qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and
>> >stores the resulting QString in a QDict.
>> >
>> >qemu_rbd_co_create_opts() and q
On 2018-07-28 06:32, Jeff Cody wrote:
> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
>>> On 07/25/2018 10:10 AM, Markus Armbruster wrote:
qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON
On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> > On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> > > qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON,
> > > and
> > > stores the resulting
On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> >qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and
> >stores the resulting QString in a QDict.
> >
> >qemu_rbd_co_create_opts() and qemu_rbd_open() get the QStr
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180725151011.25951-1-arm...@redhat.com
Subject: [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=bas
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180725151011.25951-1-arm...@redhat.com
Subject: [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=bas
On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> > qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and
> > stores the resulting QString in a QDict.
> >
> > qemu_rbd_co_create_opts() and qemu_rbd_open() get the
On 07/25/2018 10:10 AM, Markus Armbruster wrote:
qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and
stores the resulting QString in a QDict.
qemu_rbd_co_create_opts() and qemu_rbd_open() get the QString from the
QDict, pass it to qemu_rbd_set_keypairs(), which converts i
qemu_rbd_parse_filename() builds a keypairs QList, converts it to JSON, and
stores the resulting QString in a QDict.
qemu_rbd_co_create_opts() and qemu_rbd_open() get the QString from the
QDict, pass it to qemu_rbd_set_keypairs(), which converts it back into
a QList.
Drop both conversions, store
17 matches
Mail list logo
