Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Laszlo Ersek
On 03/15/13 18:55, Kevin Wolf wrote: > However this won't be the last time that I have to deal with an Error > object, so I thought I'd check what is good practice. Seems no such > thing has established yet, which is an answer, even though not the one I > was hoping for. What I've gathered from d

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Kevin Wolf
Am 15.03.2013 um 17:55 hat Laszlo Ersek geschrieben: > On 03/15/13 09:37, Kevin Wolf wrote: > > Am 14.03.2013 um 16:52 hat Laszlo Ersek geschrieben: > >> On 03/14/13 15:57, Kevin Wolf wrote: > >>> Signed-off-by: Kevin Wolf > >>> --- > >>> After rebasing this I saw that Anthony already committed a

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Laszlo Ersek
On 03/15/13 09:37, Kevin Wolf wrote: > Am 14.03.2013 um 16:52 hat Laszlo Ersek geschrieben: >> On 03/14/13 15:57, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>> After rebasing this I saw that Anthony already committed a fix that is >>> very close to my v1. I don't intend to actually c

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Kevin Wolf
Am 14.03.2013 um 16:52 hat Laszlo Ersek geschrieben: > On 03/14/13 15:57, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > After rebasing this I saw that Anthony already committed a fix that is > > very close to my v1. I don't intend to actually change that code, but as > > I've already

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-14 Thread Laszlo Ersek
On 03/14/13 15:57, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > After rebasing this I saw that Anthony already committed a fix that is > very close to my v1. I don't intend to actually change that code, but as > I've already done this, just for comparison what it would look like with > er

[Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-14 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- After rebasing this I saw that Anthony already committed a fix that is very close to my v1. I don't intend to actually change that code, but as I've already done this, just for comparison what it would look like with error propagation. Is this what you meant? I find t