Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-18 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 10:51:14AM +0800, Amos Kong wrote: > Hi Stefan, > > On Tue, Apr 16, 2013 at 10:11:50AM +0200, Stefan Hajnoczi wrote: > > On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > > Please add an optional net client name argument so the user can query > > just a single NI

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-17 Thread Amos Kong
Hi Stefan, On Tue, Apr 16, 2013 at 10:11:50AM +0200, Stefan Hajnoczi wrote: > On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > > +static MacTableInfo *virtio_net_query_mactable(NetClientState *nc) > > +{ > > +for (i = 0; i < n->mac_table.first_multi; i++) { > > +info-

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-16 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > +static MacTableInfo *virtio_net_query_mactable(NetClientState *nc) > +{ > +VirtIONet *n = qemu_get_nic_opaque(nc); > +MacTableInfo *info; > +StringList *str_list = NULL; > +StringList *entry; > +char str[12]; > +i

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Amos Kong
Hi Eric, On Thu, Apr 11, 2013 at 09:36:40AM -0600, Eric Blake wrote: > On 04/11/2013 09:11 AM, Amos Kong wrote: > > We want to do macvtap programming by libvirt, this patch added > > a monitor command to query rx mode information. I will also > > work on another patch to add QMP event notification

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Amos Kong
On Thu, Apr 11, 2013 at 06:33:02PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > > We want to do macvtap programming by libvirt, this patch added > > a monitor command to query rx mode information. I will also > > work on another patch to add QMP ev

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Eric Blake
On 04/11/2013 09:11 AM, Amos Kong wrote: > We want to do macvtap programming by libvirt, this patch added > a monitor command to query rx mode information. I will also > work on another patch to add QMP event notification for rx-mode > changing. Libvirt will sync the rx-mode change to macvtap > dev

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > We want to do macvtap programming by libvirt, this patch added > a monitor command to query rx mode information. I will also > work on another patch to add QMP event notification for rx-mode > changing. Libvirt will sync the rx-mode chang

[Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Amos Kong
We want to do macvtap programming by libvirt, this patch added a monitor command to query rx mode information. I will also work on another patch to add QMP event notification for rx-mode changing. Libvirt will sync the rx-mode change to macvtap devices, there maybe exist an un-controlled delay, gue