Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-27 Thread Markus Armbruster
Thomas Huth writes: > On Tue, 26 May 2015 17:43:09 +0100 > Stefan Hajnoczi wrote: > >> On Tue, May 26, 2015 at 3:36 PM, Daniel P. Berrange >> wrote: >> > On Tue, May 26, 2015 at 04:29:51PM +0200, Markus Armbruster wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > On Fri, May 22, 2015 at 09:22

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Paolo Bonzini
On 26/05/2015 15:07, Thomas Huth wrote: > Certainly no objections from my side to keep this "vlan" concept in > QEMU, but thinking about this option again, I'd rather call it "hub=xx" > for the -netdev option instead of "vlan=xx", since this better matches > the "-netdev hubport" naming and it IM

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Thomas Huth
On Tue, 26 May 2015 17:43:09 +0100 Stefan Hajnoczi wrote: > On Tue, May 26, 2015 at 3:36 PM, Daniel P. Berrange > wrote: > > On Tue, May 26, 2015 at 04:29:51PM +0200, Markus Armbruster wrote: > >> Stefan Hajnoczi writes: > >> > >> > On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote:

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Stefan Hajnoczi
On Tue, May 26, 2015 at 3:36 PM, Daniel P. Berrange wrote: > On Tue, May 26, 2015 at 04:29:51PM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: >> >> So far, it is not possible to use the network dump interface >> >>

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Daniel P. Berrange
On Tue, May 26, 2015 at 04:29:51PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: > >> So far, it is not possible to use the network dump interface > >> with the "-netdev" option yet, it only works with the legacy > >>

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: >> So far, it is not possible to use the network dump interface >> with the "-netdev" option yet, it only works with the legacy >> "-net" option. To be able to use it with "-netdev", too, this >> patch now enab

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Thomas Huth
On Tue, 26 May 2015 13:52:35 +0100 Stefan Hajnoczi wrote: > On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: > > So far, it is not possible to use the network dump interface > > with the "-netdev" option yet, it only works with the legacy > > "-net" option. To be able to use it with "

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-26 Thread Stefan Hajnoczi
On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: > So far, it is not possible to use the network dump interface > with the "-netdev" option yet, it only works with the legacy > "-net" option. To be able to use it with "-netdev", too, this > patch now enables the "vlan" packet distributi

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-22 Thread Eric Blake
On 05/22/2015 01:22 PM, Thomas Huth wrote: > So far, it is not possible to use the network dump interface > with the "-netdev" option yet, it only works with the legacy > "-net" option. To be able to use it with "-netdev", too, this > patch now enables the "vlan" packet distribution for the > "-net

[Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-22 Thread Thomas Huth
So far, it is not possible to use the network dump interface with the "-netdev" option yet, it only works with the legacy "-net" option. To be able to use it with "-netdev", too, this patch now enables the "vlan" packet distribution for the "-netdev" option, too, so that you can now dump network pa