Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package

2018-02-15 Thread Philippe Mathieu-Daudé
What is interesting with this patch, is that, forcing use of system capstone, Travis builds ran much faster; longest build took 40min: https://travis-ci.org/philmd/qemu/builds/341979248 This revealed (without profiling yet) that compiling the capstone C++ takes some time... mingw32@i7-4600U# time

Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package

2018-02-15 Thread miqlas
Hi, afaik (but not tested) pkgconfig --cflags reports /includes on linux, and it does the same on Haiku too. I'm not against to change our capstone recipe, but please, if you can check it on Linux and report it back, as i don't want to break other software. Thanks for the nice talk, guys! --

Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package

2018-02-15 Thread Philippe Mathieu-Daudé
Hi Sergei, On 02/15/2018 03:21 PM, Sergei Trofimovich wrote: > On Thu, 15 Feb 2018 14:35:39 -0300 > Philippe Mathieu-Daudé wrote: > >> #else >> +#include > > I think it's incorrect. 'pkg-config' already reports 'capstone/' path: > $ pkg-config --cflags capstone > -I/usr/include/capsto

Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package

2018-02-15 Thread Sergei Trofimovich
On Thu, 15 Feb 2018 14:35:39 -0300 Philippe Mathieu-Daudé wrote: > #else > +#include I think it's incorrect. 'pkg-config' already reports 'capstone/' path: $ pkg-config --cflags capstone -I/usr/include/capstone $ ls /usr/include/capstone/capstone.h /usr/include/capstone/capsto

[Qemu-devel] [RFC PATCH] capstone: fix building using system package

2018-02-15 Thread Philippe Mathieu-Daudé
The use of is recommended by the upstream project: http://www.capstone-engine.org/lang_c.html However when building the in-tree cloned submodule, the header is accessible via . This fixes building on Gentoo (and Haiku OS - not supported since 898be3e0415): CC disas.o /sources/qemu-2.