Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-05-20 Thread Yury Kotov
It's to detect those cases in the future, yes. 17.05.2019, 21:25, "Eduardo Habkost" : > My memory is failing here: do we still need to fix a bug where > there are unexpected writes to system_memory, or this is just a > request to include a mechanism to help us detect those cases in > the future? >

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-05-17 Thread Eduardo Habkost
My memory is failing here: do we still need to fix a bug where there are unexpected writes to system_memory, or this is just a request to include a mechanism to help us detect those cases in the future? On Tue, May 14, 2019 at 12:42:14PM +0300, Yury Kotov wrote: > Ping ping > > 17.04.2019, 15:

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-05-14 Thread Yury Kotov
Ping ping 17.04.2019, 15:46, "Yury Kotov" : > Ping > > 04.04.2019, 13:01, "Yury Kotov" : >>  I saw Catherine Ho's patch series and it seems ok to me, but in this RFC I >> asked >>  about a way how to detect other writes which may not be covered by >> particular >>  fixes. >>  Perhaps this is exc

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-04-17 Thread Yury Kotov
Ping 04.04.2019, 13:01, "Yury Kotov" : > I saw Catherine Ho's patch series and it seems ok to me, but in this RFC I > asked > about a way how to detect other writes which may not be covered by particular > fixes. > Perhaps this is excessive caution... > > Regards, > Yury > > 04.04.2019, 12:52, "D

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-04-04 Thread Yury Kotov
I saw Catherine Ho's patch series and it seems ok to me, but in this RFC I asked about a way how to detect other writes which may not be covered by particular fixes. Perhaps this is excessive caution... Regards, Yury 04.04.2019, 12:52, "Dr. David Alan Gilbert" : > * Юрий Котов (yury-ko...@yandex-

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-04-04 Thread Dr. David Alan Gilbert
* Юрий Котов (yury-ko...@yandex-team.ru) wrote: > Ping Is this fixed by Catherine Ho's patch series? Dave > 21.03.2019, 19:27, "Yury Kotov" : > > Hi, > > > > 19.03.2019, 14:52, "Dr. David Alan Gilbert" : > >>  * Peter Maydell (peter.mayd...@linaro.org) wrote: > >>>   On Tue, 19 Mar 2019 at 11:03

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-04-03 Thread Юрий Котов
Ping 21.03.2019, 19:27, "Yury Kotov" : > Hi, > > 19.03.2019, 14:52, "Dr. David Alan Gilbert" : >>  * Peter Maydell (peter.mayd...@linaro.org) wrote: >>>   On Tue, 19 Mar 2019 at 11:03, Dr. David Alan Gilbert >>>    wrote: >>>   > >>>   > * Peter Maydell (peter.mayd...@linaro.org) wrote: >>>   > >

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-21 Thread Yury Kotov
Hi, 19.03.2019, 14:52, "Dr. David Alan Gilbert" : > * Peter Maydell (peter.mayd...@linaro.org) wrote: >>  On Tue, 19 Mar 2019 at 11:03, Dr. David Alan Gilbert >>   wrote: >>  > >>  > * Peter Maydell (peter.mayd...@linaro.org) wrote: >>  > > I didn't think migration distinguished between "main memo

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Igor Mammedov
On Tue, 19 Mar 2019 12:53:49 + Peter Maydell wrote: > On Tue, 19 Mar 2019 at 12:42, Igor Mammedov wrote: > > on aarch(64) we also load dtb into main RAM currently only on boot, > > Hmm? We load the DTB in hw/arm/boot.c using rom_add_blob_fixed_as(), > which means that it will use this "ro

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 12:42, Igor Mammedov wrote: > on aarch(64) we also load dtb into main RAM currently only on boot, Hmm? We load the DTB in hw/arm/boot.c using rom_add_blob_fixed_as(), which means that it will use this "rom blob loading" mechanism, so it should be re-copied into RAM on reset

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Igor Mammedov
On Tue, 19 Mar 2019 11:52:45 + "Dr. David Alan Gilbert" wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Tue, 19 Mar 2019 at 11:03, Dr. David Alan Gilbert > > wrote: > > > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > > I didn't think migration distinguis

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 19 Mar 2019 at 11:03, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > I didn't think migration distinguished between "main memory" > > > and any other kind of RAMBlock-backed memory ? > > >

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 11:03, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > I didn't think migration distinguished between "main memory" > > and any other kind of RAMBlock-backed memory ? > > In Yury's case there's a distinction between RAMBlock's that are

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 19 Mar 2019 at 09:40, Dr. David Alan Gilbert > wrote: > > I thought that ROMs would either: > >a) Be mapped shared from a file but then read-only and unwritten > > I don't think we support this at all, do we? OK, I thought we did so

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Yury Kotov
19.03.2019, 12:39, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  This patch isn't intended to merge. Just to reproduce a problem. >> >>  The test for x-ignore-shread capability fails on aarch64 + tcg: >>  Memory content inconsistency at 44c0 first_byte = 2 las

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 09:40, Dr. David Alan Gilbert wrote: > I thought that ROMs would either: >a) Be mapped shared from a file but then read-only and unwritten I don't think we support this at all, do we? > or >b) Be written to during boot - but this wouldn't be main memory, so > would

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 19 Mar 2019 at 07:36, Jia He wrote: > > > > Thanks Yury. > > > > On 2019/3/14 19:03, Yury Kotov wrote: > > > This patch isn't intended to merge. Just to reproduce a problem. > > > > > > The test for x-ignore-shread capability fails on aar

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > This patch isn't intended to merge. Just to reproduce a problem. > > The test for x-ignore-shread capability fails on aarch64 + tcg: > Memory content inconsistency at 44c0 first_byte = 2 last_byte = 1 current > = d1 hit_edge = 1 > Memory conte

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 07:36, Jia He wrote: > > Thanks Yury. > > On 2019/3/14 19:03, Yury Kotov wrote: > > This patch isn't intended to merge. Just to reproduce a problem. > > > > The test for x-ignore-shread capability fails on aarch64 + tcg: > > Memory content inconsistency at 44c0 first_byt

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Jia He
Thanks Yury. On 2019/3/14 19:03, Yury Kotov wrote: This patch isn't intended to merge. Just to reproduce a problem. The test for x-ignore-shread capability fails on aarch64 + tcg: Memory content inconsistency at 44c0 first_byte = 2 last_byte = 1 current = d1 hit_edge = 1 Memory content inc

[Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-14 Thread Yury Kotov
This patch isn't intended to merge. Just to reproduce a problem. The test for x-ignore-shread capability fails on aarch64 + tcg: Memory content inconsistency at 44c0 first_byte = 2 last_byte = 1 current = d1 hit_edge = 1 Memory content inconsistency at 44c01000 first_byte = 2 last_byte = 1 cu