Re: [Qemu-devel] [RFC 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-06-25 Thread Stefan Hajnoczi
On Mon, Jun 25, 2012 at 4:10 PM, Kevin Wolf wrote: > Am 22.06.2012 17:08, schrieb Stefan Hajnoczi: >> +echo >> +echo "== Read-only access must still work ==" >> + >> +$QEMU_IO -r -c "read -P 0x5a 0 512" $TEST_IMG | _filter_qemu_io > > I would add a check here that the dirty bit is still set. > > M

Re: [Qemu-devel] [RFC 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-06-25 Thread Kevin Wolf
Am 22.06.2012 17:08, schrieb Stefan Hajnoczi: > This tests establishes the basic post-conditions of the qcow2 lazy > refcounts features: > > 1. If the image was closed normally, it is marked clean. > > 2. If an allocating write was performed and the image was not close > normally, then i

[Qemu-devel] [RFC 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-06-22 Thread Stefan Hajnoczi
This tests establishes the basic post-conditions of the qcow2 lazy refcounts features: 1. If the image was closed normally, it is marked clean. 2. If an allocating write was performed and the image was not close normally, then it is marked dirty. a. Written data can be read back su