Re: [Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations

2016-07-21 Thread Richard Henderson
On 07/21/2016 01:41 PM, Nikunj A Dadhania wrote: It would probably be better to use helper functions for both div and mod, because of the branches required. C.f. target-arm/helper-a64.c, helper_sdiv64 et al. What is the thumb rule to implement it has helper? As I am implementing other instruct

Re: [Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations

2016-07-21 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/18/2016 10:38 AM, Nikunj A Dadhania wrote: >> David Gibson writes: >> >>> [ Unknown signature status ] >>> On Tue, Jul 12, 2016 at 11:33:21PM +0530, Nikunj A Dadhania wrote: Adding following instructions: moduw: Modulo Unsigned Word modsw: Mo

Re: [Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations

2016-07-20 Thread Richard Henderson
On 07/18/2016 10:38 AM, Nikunj A Dadhania wrote: David Gibson writes: [ Unknown signature status ] On Tue, Jul 12, 2016 at 11:33:21PM +0530, Nikunj A Dadhania wrote: Adding following instructions: moduw: Modulo Unsigned Word modsw: Modulo Signed Word Signed-off-by: Nikunj A Dadhania Hrm.

Re: [Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations

2016-07-17 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Tue, Jul 12, 2016 at 11:33:21PM +0530, Nikunj A Dadhania wrote: >> Adding following instructions: >> >> moduw: Modulo Unsigned Word >> modsw: Modulo Signed Word >> >> Signed-off-by: Nikunj A Dadhania > > Hrm.. any reason you're not using

Re: [Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations

2016-07-17 Thread David Gibson
On Tue, Jul 12, 2016 at 11:33:21PM +0530, Nikunj A Dadhania wrote: > Adding following instructions: > > moduw: Modulo Unsigned Word > modsw: Modulo Signed Word > > Signed-off-by: Nikunj A Dadhania Hrm.. any reason you're not using the TCG inbuilt remainder ops (tcg_gen_rem_i32() etc.)? > --- >

[Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations

2016-07-12 Thread Nikunj A Dadhania
Adding following instructions: moduw: Modulo Unsigned Word modsw: Modulo Signed Word Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/target-ppc/translate.c b/target-ppc/translate.