Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2015 at 07:35:05PM +0200, Max Reitz wrote: > On 12.06.2015 12:09, Stefan Hajnoczi wrote: > >Reclaim the dirty bitmap if an incremental backup block job is > >cancelled. The ret variable may be 0 when the job is cancelled so it's > >not enough to check ret < 0. > > > >Signed-off-by:

Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled

2015-06-24 Thread Max Reitz
On 12.06.2015 12:09, Stefan Hajnoczi wrote: Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret < 0. Signed-off-by: Stefan Hajnoczi --- block/backup.c | 2 +- 1 file changed, 1 insertio

Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled

2015-06-15 Thread Stefan Hajnoczi
On Fri, Jun 12, 2015 at 06:39:19PM -0400, John Snow wrote: > > > On 06/12/2015 06:09 AM, Stefan Hajnoczi wrote: > > Reclaim the dirty bitmap if an incremental backup block job is > > cancelled. The ret variable may be 0 when the job is cancelled so it's > > not enough to check ret < 0. > > > >

Re: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled

2015-06-12 Thread John Snow
On 06/12/2015 06:09 AM, Stefan Hajnoczi wrote: > Reclaim the dirty bitmap if an incremental backup block job is > cancelled. The ret variable may be 0 when the job is cancelled so it's > not enough to check ret < 0. > > Signed-off-by: Stefan Hajnoczi > --- > block/backup.c | 2 +- > 1 file ch

[Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled

2015-06-12 Thread Stefan Hajnoczi
Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret < 0. Signed-off-by: Stefan Hajnoczi --- block/backup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/backup.c