Re: [Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc

2013-03-10 Thread Stefan Hajnoczi
On Sun, Mar 10, 2013 at 11:05 AM, Dietmar Maurer wrote: >> Remove the BackupDumpFunc function pointer and write directly to a >> BlockDriverState. > > My callback approach is the generic one. You can easily implement the > BlockDriverState approach using the BackupDumpFunc? Yes it can be implemen

Re: [Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc

2013-03-10 Thread Dietmar Maurer
> Remove the BackupDumpFunc function pointer and write directly to a > BlockDriverState. My callback approach is the generic one. You can easily implement the BlockDriverState approach using the BackupDumpFunc?

[Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc

2013-03-09 Thread Stefan Hajnoczi
Remove the BackupDumpFunc function pointer and write directly to a BlockDriverState. This allows the 'backup' command to copy out into a fresh qcow2 or raw image. If no built-in image format is suitable, use NBD to export the data to an external process. A few other things in this commit: * Det