Re: [Qemu-devel] [RFC 24/38] cpu-exec: reset mmap_lock after exiting the CPU loop

2015-08-25 Thread Emilio G. Cota
On Sun, Aug 23, 2015 at 19:01:39 -0700, Paolo Bonzini wrote: > On 23/08/2015 17:23, Emilio G. Cota wrote: > > Otherwise after an exception we end up in a deadlock. > > Can you explain better the path that exits cpu_exec with the lock taken? In fact I cannot :-) So please ignore this patch. I wro

Re: [Qemu-devel] [RFC 24/38] cpu-exec: reset mmap_lock after exiting the CPU loop

2015-08-24 Thread Paolo Bonzini
On 23/08/2015 17:23, Emilio G. Cota wrote: > Otherwise after an exception we end up in a deadlock. Can you explain better the path that exits cpu_exec with the lock taken? Also, let's remove the recursive locking by introducing "mmap_lock() already taken" variants of target_mprotect and target_

[Qemu-devel] [RFC 24/38] cpu-exec: reset mmap_lock after exiting the CPU loop

2015-08-24 Thread Emilio G. Cota
Otherwise after an exception we end up in a deadlock. Signed-off-by: Emilio G. Cota --- bsd-user/mmap.c | 12 cpu-exec.c | 1 + include/exec/exec-all.h | 2 ++ linux-user/mmap.c | 8 4 files changed, 23 insertions(+) diff --git a/bsd-user/mmap