Re: [Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-10 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 12:36:35AM +0100, Igor Mammedov wrote: [...] > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 33787dc..f34192c 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -23,6 +23,8 @@ > > > > #include "cpu.h" > > #include "sysemu/kvm.h" > > +#

Re: [Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-10 Thread Igor Mammedov
On Wed, 9 Jan 2013 16:53:52 -0200 Eduardo Habkost wrote: > This keeps compatibility on machine-types pc-1.2 and older, and prints a > warning in case the requested configuration won't get the correct > topology. > > I couldn't think of a better way to warn about broken topology when in > compat

[Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-09 Thread Eduardo Habkost
This keeps compatibility on machine-types pc-1.2 and older, and prints a warning in case the requested configuration won't get the correct topology. I couldn't think of a better way to warn about broken topology when in compat mode other than using error_report(). The warning message will be proba