Re: [Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry

2015-07-03 Thread Markus Armbruster
John Snow writes: > Lessen the number of parameters it takes. > > Signed-off-by: John Snow Haven't reviewed in detail, but: YES, please!

[Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry

2015-06-30 Thread John Snow
Lessen the number of parameters it takes. Signed-off-by: John Snow --- hw/block/fdc.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index be6bf25..4004b98 100644 --- a/hw/block/fdc.c +++ b/hw/block/fd