Re: [Qemu-devel] [RFC 04/10] ide: Correct handling of malformed/short PRDTs

2014-09-13 Thread Paolo Bonzini
Il 13/09/2014 06:34, John Snow ha scritto: > This impacts both BMDMA and AHCI HBA interfaces for IDE. > Currently, we confuse the difference between a PRD having > "0 bytes" and a PRD having "0 complete sectors." > > This leads to, in the BMDMA case, leaked memory for short PRDTs, > and infinite l

[Qemu-devel] [RFC 04/10] ide: Correct handling of malformed/short PRDTs

2014-09-12 Thread John Snow
This impacts both BMDMA and AHCI HBA interfaces for IDE. Currently, we confuse the difference between a PRD having "0 bytes" and a PRD having "0 complete sectors." This leads to, in the BMDMA case, leaked memory for short PRDTs, and infinite loops in the AHCI case. the "prepare_buf" callback is r