Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-07-11 Thread David Hildenbrand
> Are there any further comments, especially on patches 23-25, introducing new > QOM interfaces? Ping, can somebody please have a look, especially on patches 23-25? We really want to know if we can proceed with this CPU model approach. David > > Also, if anybody is planning to look into this, p

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-30 Thread Eduardo Habkost
On Thu, Jun 30, 2016 at 09:32:04AM +0200, David Hildenbrand wrote: > > Are there any further comments, especially on patches 23-25, introducing new > QOM interfaces? > > Also, if anybody is planning to look into this, please speak up :) I am still planning to look at this (I didn't look at the i

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-30 Thread David Hildenbrand
Are there any further comments, especially on patches 23-25, introducing new QOM interfaces? Also, if anybody is planning to look into this, please speak up :) Otherwise it might make sense to put this onto the next KVM call agenda. David > This is our second attempt to implement CPU models fo

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread David Hildenbrand
> On Wed, Jun 22, 2016 at 09:54:51 +0200, David Hildenbrand wrote: > > > On Wed, Jun 22, 2016 at 09:34:49 +0200, David Hildenbrand wrote: > > > > I think the coffee didn't do its work already :) . I wanted to write > > > > that we can > > > > _with_ this additional query. Meaning the involved ov

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread David Hildenbrand
> Question: KVM supports x2apic (and enables it by default) on any > host CPU, because it is all emulated by KVM. Should "host-model" > include x2apic on all hosts, or only when the host CPU has it? > ("-cpu host" does include it). > > Including x2apic sounds more useful, but it doesn't match the

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread Eduardo Habkost
On Tue, Jun 21, 2016 at 10:56:28PM +0200, Jiri Denemark wrote: [...] > Let me sum up what libvirt is doing (or will be doing) with guest > CPUs... Libvirt supports three guest CPU configuration modes: > > - host-passthrough -- this is easy, it's just asking for "-cpu host" and > no fancy command

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread Jiri Denemark
On Wed, Jun 22, 2016 at 09:54:51 +0200, David Hildenbrand wrote: > > On Wed, Jun 22, 2016 at 09:34:49 +0200, David Hildenbrand wrote: > > > I think the coffee didn't do its work already :) . I wanted to write that > > > we can > > > _with_ this additional query. Meaning the involved overhead would

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread David Hildenbrand
> On Wed, Jun 22, 2016 at 09:34:49 +0200, David Hildenbrand wrote: > > I think the coffee didn't do its work already :) . I wanted to write that > > we can > > _with_ this additional query. Meaning the involved overhead would be ok - > > in my > > opinion for s390x. > > > > What we could do to a

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread Jiri Denemark
On Wed, Jun 22, 2016 at 09:34:49 +0200, David Hildenbrand wrote: > I think the coffee didn't do its work already :) . I wanted to write that we > can > _with_ this additional query. Meaning the involved overhead would be ok - in > my > opinion for s390x. > > What we could do to avoid one compare

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread David Hildenbrand
> > > > 2) Requiring a running QEMU instance to run > > > >query-cpu-model-comparison > > > > > > > > With my previous query-host-cpu proposal, the task of comparing > > > > the configuration requested by the user with host capabilities > > > > can be done directly by libvirt. This way, no ex

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-22 Thread Jiri Denemark
On Wed, Jun 22, 2016 at 08:51:40 +0200, David Hildenbrand wrote: > > On Tue, Jun 21, 2016 at 17:33:09 -0300, Eduardo Habkost wrote: > > > On Tue, Jun 21, 2016 at 07:01:44PM +0200, David Hildenbrand wrote: > > > I still don't think we want to set in stone that "the result the > > > guest sees when

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread David Hildenbrand
> On Tue, Jun 21, 2016 at 17:33:09 -0300, Eduardo Habkost wrote: > > On Tue, Jun 21, 2016 at 07:01:44PM +0200, David Hildenbrand wrote: > > > > (CCing libvirt people) > > > > > > > > On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > > > > > This is our second attempt to impl

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread David Hildenbrand
> On Tue, Jun 21, 2016 at 13:44:31 -0300, Eduardo Habkost wrote: > > (CCing libvirt people) > > > > On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > > > This is our second attempt to implement CPU models for s390x. We realized > > > that we also want to have features exposed vi

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread Eduardo Habkost
On Tue, Jun 21, 2016 at 11:09:49PM +0200, Jiri Denemark wrote: [...] > > 1) "query-cpu-model-expansion model=host" vs "query-host-cpu": > > > > I still don't think we want to set in stone that "the result the > > guest sees when using -cpu host" is always the same as "what the > > host supports ru

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread Jiri Denemark
On Tue, Jun 21, 2016 at 17:33:09 -0300, Eduardo Habkost wrote: > On Tue, Jun 21, 2016 at 07:01:44PM +0200, David Hildenbrand wrote: > > > (CCing libvirt people) > > > > > > On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > > > > This is our second attempt to implement CPU models

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread Jiri Denemark
On Tue, Jun 21, 2016 at 13:44:31 -0300, Eduardo Habkost wrote: > (CCing libvirt people) > > On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > > This is our second attempt to implement CPU models for s390x. We realized > > that we also want to have features exposed via the CPU mo

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread Eduardo Habkost
On Tue, Jun 21, 2016 at 07:01:44PM +0200, David Hildenbrand wrote: > > (CCing libvirt people) > > > > On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > > > This is our second attempt to implement CPU models for s390x. We realized > > > that we also want to have features exposed

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread David Hildenbrand
> (CCing libvirt people) > > On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > > This is our second attempt to implement CPU models for s390x. We realized > > that we also want to have features exposed via the CPU model. While doing > > that we realized that we want to have a be

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread Eduardo Habkost
(CCing libvirt people) On Tue, Jun 21, 2016 at 03:02:05PM +0200, David Hildenbrand wrote: > This is our second attempt to implement CPU models for s390x. We realized > that we also want to have features exposed via the CPU model. While doing > that we realized that we want to have a better interfa

[Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-21 Thread David Hildenbrand
This is our second attempt to implement CPU models for s390x. We realized that we also want to have features exposed via the CPU model. While doing that we realized that we want to have a better interface for libvirt. Unfortunately, CPU models on s390x are special and we have to take care of: - A