Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Luiz Capitulino
On Tue, 26 Jan 2010 15:57:46 + Jamie Lokier wrote: > Daniel P. Berrange wrote: > > On Tue, Jan 26, 2010 at 12:57:54PM +, Jamie Lokier wrote: > > > Luiz Capitulino wrote: > > > > capability_enable [ "foo", "bar" ] > > > > > > > > Now, only one command is not terrible difficult, but we wo

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Jamie Lokier
Daniel P. Berrange wrote: > On Tue, Jan 26, 2010 at 12:57:54PM +, Jamie Lokier wrote: > > Luiz Capitulino wrote: > > > capability_enable [ "foo", "bar" ] > > > > > > Now, only one command is not terrible difficult, but we would > > > have to accept an array of objects, like: > > > > > > [ {

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Daniel P. Berrange
On Tue, Jan 26, 2010 at 12:57:54PM +, Jamie Lokier wrote: > Luiz Capitulino wrote: > > capability_enable [ "foo", "bar" ] > > > > Now, only one command is not terrible difficult, but we would > > have to accept an array of objects, like: > > > > [ { "name": "foo", "enabled": true }, { "name"

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Luiz Capitulino
On Tue, 26 Jan 2010 12:57:54 + Jamie Lokier wrote: > Luiz Capitulino wrote: > > capability_enable [ "foo", "bar" ] > > > > Now, only one command is not terrible difficult, but we would > > have to accept an array of objects, like: > > > > [ { "name": "foo", "enabled": true }, { "name": "ba

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Jamie Lokier
Luiz Capitulino wrote: > capability_enable [ "foo", "bar" ] > > Now, only one command is not terrible difficult, but we would > have to accept an array of objects, like: > > [ { "name": "foo", "enabled": true }, { "name": "bar", "enabled": true } ] That looks like XML-itis. Why not { "foo": tr

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-26 Thread Luiz Capitulino
On Mon, 25 Jan 2010 15:33:40 +0100 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 01/21/2010 03:09 PM, Luiz Capitulino wrote: > >> """ > >> {"QMP": {"capabilities": ["async messages"]}} > >> > >> { "execute": "query-qmp-mode" } > >> {"return": {"mode": "handshake"}} > >> > >> { "ex

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-25 Thread Markus Armbruster
Anthony Liguori writes: > On 01/21/2010 03:09 PM, Luiz Capitulino wrote: >> """ >> {"QMP": {"capabilities": ["async messages"]}} >> >> { "execute": "query-qmp-mode" } >> {"return": {"mode": "handshake"}} >> >> { "execute": "change", "arguments": { "device": "vnc", "target": "password", >> "arg":

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-22 Thread Anthony Liguori
On 01/21/2010 03:09 PM, Luiz Capitulino wrote: """ {"QMP": {"capabilities": ["async messages"]}} { "execute": "query-qmp-mode" } {"return": {"mode": "handshake"}} { "execute": "change", "arguments": { "device": "vnc", "target": "password", "arg": "1234" } } {"error": {"class": "QMPInvalidModeC

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-22 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 22 Jan 2010 11:21:22 +0100 > Markus Armbruster wrote: > >> A few quick questions before I dive into the patches... >> >> Luiz Capitulino writes: >> >> > Feature negotiation allows clients to enable QMP capabilities they are >> > interested in using. This all

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-22 Thread Luiz Capitulino
On Fri, 22 Jan 2010 11:21:22 +0100 Markus Armbruster wrote: > A few quick questions before I dive into the patches... > > Luiz Capitulino writes: > > > Feature negotiation allows clients to enable QMP capabilities they are > > interested in using. This allows QMP to envolve without breaking o

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-22 Thread Markus Armbruster
A few quick questions before I dive into the patches... Luiz Capitulino writes: > Feature negotiation allows clients to enable QMP capabilities they are > interested in using. This allows QMP to envolve without breaking old clients. > > A capability is a new QMP feature and/or protocol change

[Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-21 Thread Luiz Capitulino
Feature negotiation allows clients to enable QMP capabilities they are interested in using. This allows QMP to envolve without breaking old clients. A capability is a new QMP feature and/or protocol change which is not part of the core protocol as defined in the QMP spec. Feature negotiation i